Web MIDI: MIDIAccessor platform implementation and Blink API

public/platform/WebMIDIAccessorClient.h

+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebMIDIAccessorClient_h
+#define WebMIDIAccessorClient_h
+
+#include "WebString.h"
+
+namespace WebKit {
+
+// Abstract client interface to the Chromium MIDI system.

[abarth-chromium, 2013/06/19 17:08:59]

This comment isn't necessary.

[Chris Rogers, 2013/06/19 19:43:31]

Done.

+
+class WebMIDIAccessorClient {
+public:
+    virtual void addInputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version) = 0;
+    virtual void addOutputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version) = 0;

[abarth-chromium, 2013/06/19 17:08:59]

Do these functions instruct the callee to add these ports?  If they're
notifications, they should be named in a notification style (e.g.,
didAddInputPort / didAddOutputPort).

[Chris Rogers, 2013/06/19 19:43:31]

Done.

+
+    virtual void accessApproved(bool approved) = 0;

[abarth-chromium, 2013/06/19 17:08:59]

What does it mean to call accessApproved(false) ?  Does that mean the access
wasn't approved?  Maybe didAllowAccess and didBlockAccess?

[Chris Rogers, 2013/06/19 19:43:31]

Done.

+    virtual void receiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) = 0;

[abarth-chromium, 2013/06/19 17:08:59]

didReceiveMIDIData ?

Should we have a comment here saying that |timeStamp| is in milliseconds also?

[Chris Rogers, 2013/06/19 19:43:31]

Done.

+
+protected:
+    virtual ~WebMIDIAccessorClient() { }
+};
+
+} // namespace WebKit
+
+#endif // WebMIDIAccessorClient_h