Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 17153012: Pepper: Don't emit structs with no wrapping. (Closed)

Created:
7 years, 6 months ago by teravest
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Don't emit structs with no wrapping. The behavior in the PNaCl shim layer is the same if there's a struct for an interface with no wrapper or no struct at all. This change removes structs where no wrapping is necessary. BUG=251460 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207839

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Fix up comments. #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -517 lines) Patch
M ppapi/generators/idl_gen_wrapper.py View 1 2 5 chunks +12 lines, -11 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 29 chunks +2 lines, -506 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
teravest
7 years, 6 months ago (2013-06-20 18:33:29 UTC) #1
jvoung (off chromium)
https://codereview.chromium.org/17153012/diff/2001/ppapi/generators/idl_gen_wrapper.py File ppapi/generators/idl_gen_wrapper.py (right): https://codereview.chromium.org/17153012/diff/2001/ppapi/generators/idl_gen_wrapper.py#newcode160 ppapi/generators/idl_gen_wrapper.py:160: /* We don't have an IDL for this, for ...
7 years, 6 months ago (2013-06-20 19:46:57 UTC) #2
teravest
On Thu, Jun 20, 2013 at 1:46 PM, <jvoung@chromium.org> wrote: > > https://codereview.chromium.org/17153012/diff/2001/ppapi/generators/idl_gen_wrapper.py > File ...
7 years, 6 months ago (2013-06-20 19:51:09 UTC) #3
jvoung (off chromium)
LGTM thanks!
7 years, 6 months ago (2013-06-20 19:53:49 UTC) #4
dmichael (off chromium)
rubber stamp lgtm
7 years, 6 months ago (2013-06-20 19:55:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/17153012/7001
7 years, 6 months ago (2013-06-20 19:56:44 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=11238
7 years, 6 months ago (2013-06-21 09:00:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/17153012/13003
7 years, 6 months ago (2013-06-21 14:07:58 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 15:58:52 UTC) #9
Message was sent while issue was closed.
Change committed as 207839

Powered by Google App Engine
This is Rietveld 408576698