chrome/browser/ui/tabs/tab_strip_model.cc - Issue 17153008: Move histograms and supporting code that don't belong in content out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 17153008: Move histograms and supporting code that don't belong in content out. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc

index 78c8f0e1fa9620c82c4bac5195361223f1d84cdb..a550ca0eac4eb795918b20af92e459524c5ebfc8 100644

--- a/chrome/browser/ui/tabs/tab_strip_model.cc

+++ b/chrome/browser/ui/tabs/tab_strip_model.cc

@@ -1115,7 +1115,9 @@ bool TabStripModel::InternalCloseTabs(const std::vector<int>& indices,

if (index == kNoTab)

continue;

- closing_contents->OnCloseStarted();

+ CoreTabHelper* core_tab_helper =

+ CoreTabHelper::FromWebContents(closing_contents);

+ core_tab_helper->OnCloseStarted();

// Update the explicitly closed state. If the unload handlers cancel the

// close the state is reset in Browser. We don't update the explicitly