Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 17153008: Move histograms and supporting code that don't belong in content out. (Closed)

Created:
7 years, 6 months ago by jeremy
Modified:
7 years, 6 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, jar (doing other things), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, ajwong+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Move histograms and supporting code that don't belong in content out. This CL was originally based on top of r205149 (Fast Tab Closure) and committed as r207181. The Fast Tab Closure CL was backed out together with the previous version of this CL. Here's another shot, doing the same cleanup as before but with r205149 reverted. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -57 lines) Patch
M chrome/browser/ui/browser_tabstrip.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.h View 2 chunks +32 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 3 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/metrics_handler.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +4 lines, -26 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jeremy
Thanks for the original cleanup!!
7 years, 6 months ago (2013-06-20 10:49:51 UTC) #1
jeremy
FYI: The revert is making it's way through the CQ at the moment so it ...
7 years, 6 months ago (2013-06-20 11:02:20 UTC) #2
Avi (use Gerrit)
SLGTM
7 years, 6 months ago (2013-06-20 14:55:08 UTC) #3
jam
lgtm
7 years, 6 months ago (2013-06-20 15:38:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/17153008/1
7 years, 6 months ago (2013-06-21 15:30:31 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 21:29:14 UTC) #6
Message was sent while issue was closed.
Change committed as 207925

Powered by Google App Engine
This is Rietveld 408576698