command_buffer_gles2: Implement EGL default Display as a global object

gpu/gles2_conform_support/native/egl_native_windowless.cc

Index: gpu/gles2_conform_support/native/egl_native_windowless.cc
diff --git a/gpu/gles2_conform_support/native/egl_native_windowless.cc b/gpu/gles2_conform_support/native/egl_native_windowless.cc
index 725d0a05083fb76380e5a9e0bb471925404af07d..1bb0b8905758963dcf4827a1ccada1da8b6a3570 100644
--- a/gpu/gles2_conform_support/native/egl_native_windowless.cc
+++ b/gpu/gles2_conform_support/native/egl_native_windowless.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "gpu/gles2_conform_support/egl/display.h"
+#include "gpu/gles2_conform_support/egl/test_support.h"  // nogncheck

[Kimmo Kinnunen, 2016/04/12 12:21:12]

I'm trying to fix the GN error with //nogncheck.

[vabr (Chromium), 2016/04/12 12:32:01]

GN complains that this header is not in any dependency of the "egl" source_set
in which this file is built. And GN is correct about it. The header is in the
target command_buffer_gles2 in //gpu/BUIL.gn.

Without any knowledge of this code, the right thing to do seems to be to add the
dependency on command_buffer_gles2 to the egl source_set.

If some GPU OWNERS have good reasons for this not to be the case and approve of
masking this error, I won't interfere. But building a great build system for
keeping the dependencies sane, and then breaking them arbitrarily seems
counter-productive.

 
 extern "C" {
 #if defined(GLES2_CONFORM_SUPPORT_ONLY)
@@ -24,8 +24,8 @@ GTFbool GTFNativeCreateWindow(EGLNativeDisplayType nativeDisplay,
                               EGLDisplay eglDisplay, EGLConfig eglConfig,
                               const char* title, int width, int height,
                               EGLNativeWindowType *pNativeWindow) {
-  egl::Display* display = static_cast<egl::Display*>(eglDisplay);
-  display->SetCreateOffscreen(width, height);
+  CommandBufferGLESSetNextCreateWindowSurfaceCreatesPBuffer(eglDisplay, width,
+                                                            height);
   return GTFtrue;
 }