Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 17137008: Extract HTMLImportLoader from LinkImport (Closed)

Created:
7 years, 6 months ago by Hajime Morrita
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Extract HTMLImportLoader from LinkImport This change extract loading facility and ownership of imported document from LinkImport to HTMLImportLoader, by doing this, sharing import between <link>s can be represented in straightforward way. Before this change, all shared imports of an URL become unavailable once the first <link> is removed from tree. This extraction fixes the problem. BUG=240592 TEST=import-shared-remove.html R=dglazkov R=dominicc Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152698

Patch Set 1 #

Total comments: 1

Patch Set 2 : For landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -85 lines) Patch
A LayoutTests/fast/html/imports/import-shared-remove.html View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-shared-remove-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImportsController.h View 1 3 chunks +29 lines, -17 lines 0 comments Download
M Source/core/html/HTMLImportsController.cpp View 3 chunks +74 lines, -68 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
Could you take a look? This is a preparation for implementing subimport.
7 years, 6 months ago (2013-06-19 02:23:23 UTC) #1
dglazkov
lgtm + nit: https://codereview.chromium.org/17137008/diff/1/Source/core/html/HTMLImportsController.h File Source/core/html/HTMLImportsController.h (right): https://codereview.chromium.org/17137008/diff/1/Source/core/html/HTMLImportsController.h#newcode49 Source/core/html/HTMLImportsController.h:49: class LinkImport : public LinkResource, CachedResourceClient ...
7 years, 6 months ago (2013-06-19 02:53:52 UTC) #2
Hajime Morrita
On 2013/06/19 02:53:52, Dimitri Glazkov wrote: > lgtm + nit: > > https://codereview.chromium.org/17137008/diff/1/Source/core/html/HTMLImportsController.h > File ...
7 years, 6 months ago (2013-06-19 03:37:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/17137008/6001
7 years, 6 months ago (2013-06-19 03:40:07 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 05:36:22 UTC) #5
Message was sent while issue was closed.
Change committed as 152698

Powered by Google App Engine
This is Rietveld 408576698