Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 17136003: [Android WebView] Fallback tick (Closed)

Created:
7 years, 6 months ago by boliu
Modified:
7 years, 6 months ago
Reviewers:
joth
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Fallback tick If we call up view invalidate and OnDraw is not called before a deadline, then we keep ticking the SynchronousCompositor so it can make progress. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207999

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M android_webview/browser/in_process_view_renderer.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M android_webview/browser/in_process_view_renderer.cc View 1 2 7 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
boliu
7 years, 6 months ago (2013-06-21 19:06:56 UTC) #1
joth
lgtm https://codereview.chromium.org/17136003/diff/2001/android_webview/browser/in_process_view_renderer.cc File android_webview/browser/in_process_view_renderer.cc (right): https://codereview.chromium.org/17136003/diff/2001/android_webview/browser/in_process_view_renderer.cc#newcode706 android_webview/browser/in_process_view_renderer.cc:706: base::Unretained(this))); comment cancelation https://codereview.chromium.org/17136003/diff/2001/android_webview/browser/in_process_view_renderer.cc#newcode716 android_webview/browser/in_process_view_renderer.cc:716: void InProcessViewRenderer::FallbackTick() { ...
7 years, 6 months ago (2013-06-21 20:22:01 UTC) #2
boliu
Also removed InProcessViewRenderer::RenderSW and call CompositeSW directly. https://codereview.chromium.org/17136003/diff/2001/android_webview/browser/in_process_view_renderer.cc File android_webview/browser/in_process_view_renderer.cc (right): https://codereview.chromium.org/17136003/diff/2001/android_webview/browser/in_process_view_renderer.cc#newcode706 android_webview/browser/in_process_view_renderer.cc:706: base::Unretained(this))); On ...
7 years, 6 months ago (2013-06-21 21:49:40 UTC) #3
joth
lgtm
7 years, 6 months ago (2013-06-21 21:54:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/17136003/7001
7 years, 6 months ago (2013-06-22 03:41:02 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 03:45:20 UTC) #6
Message was sent while issue was closed.
Change committed as 207999

Powered by Google App Engine
This is Rietveld 408576698