Auto-closing at unexpected EOF for all entry points.

Auto-closing at unexpected EOF for all entry points.

Don't wrap non-stylesheet (CSSOM rule, selectors, etc) input strings to CSS
parser in braces as that will break auto-closing of blocks, parentheses, etc
in the actual input string.

BUG=163354
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152717

[SeRya, 2013-06-16 09:52:37]

lgtm

https://codereview.chromium.org/17129003/diff/1/Source/core/css/CSSGrammar.y.in
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/17129003/diff/1/Source/core/css/CSSGrammar.y....
Source/core/css/CSSGrammar.y.in:332: INTERNAL_RULE_SYM maybe_space valid_rule
maybe_space TOKEN_EOF {
Wouldn't it work equally fine without TOKEN_EOF at the end?

[rune, 2013-06-16 18:59:12]

On 2013/06/16 09:52:37, SeRya wrote:
>
https://codereview.chromium.org/17129003/diff/1/Source/core/css/CSSGrammar.y....
> Source/core/css/CSSGrammar.y.in:332: INTERNAL_RULE_SYM maybe_space valid_rule
> maybe_space TOKEN_EOF {
> Wouldn't it work equally fine without TOKEN_EOF at the end?

No, without the TOKEN_EOF an input string that contains a valid rule followed by
garbage will be accepted as the valid rule. I'll that as a LayoutTest.

[rune, 2013-06-16 19:13:47]

On 2013/06/16 18:59:12, rune wrote:
> No, without the TOKEN_EOF an input string that contains a valid rule followed
by
> garbage will be accepted as the valid rule. I'll that as a LayoutTest.

Test added in Patch Set 2.

[apavlov, 2013-06-19 10:36:12]

lgtm

[commit-bot: I haz the power, 2013-06-19 10:38:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/17129003/6001

[commit-bot: I haz the power, 2013-06-19 10:38:49]

Failed to apply patch for LayoutTests/css3/supports-cssom-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/css3/supports-cssom-expected.txt
  Hunk #1 FAILED at 30.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/css3/supports-cssom-expected.txt.rej

Patch:       LayoutTests/css3/supports-cssom-expected.txt
Index: LayoutTests/css3/supports-cssom-expected.txt
diff --git a/LayoutTests/css3/supports-cssom-expected.txt
b/LayoutTests/css3/supports-cssom-expected.txt
index
e6241adb170be166e236a870fdc8cd0a634bfcdf..f82f3ebc495d91188bbb680f997650ca9a4cd8f4
100644
--- a/LayoutTests/css3/supports-cssom-expected.txt
+++ b/LayoutTests/css3/supports-cssom-expected.txt
@@ -30,7 +30,7 @@ PASS rules[0].cssRules.length is 2
 @charset, @namespace, @import rules are not allowed inside @supports.
 PASS rules[0].insertRule('@charset "UTF-8"', 2) threw exception Error:
SyntaxError: DOM Exception 12.
 PASS rules[0].insertRule('@namespace ""', 2) threw exception Error:
SyntaxError: DOM Exception 12.
-PASS rules[0].insertRule('@import url("../fast/cssom/resources/import.css")',
2) threw exception Error: SyntaxError: DOM Exception 12.
+PASS rules[0].insertRule('@import url("../fast/cssom/resources/import.css")',
2) threw exception Error: HierarchyRequestError: DOM Exception 3.
 
 Whitespace and formatting should be preserved within the condition, whitespace
outside the condition should be trimmed.
 PASS rules[1].conditionText is "((  (     padding: 0)    and (display: none))
or (display: rainbow))"

[commit-bot: I haz the power, 2013-06-19 11:34:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/17129003/17001

[commit-bot: I haz the power, 2013-06-19 12:18:23]

Change committed as 152717