Refine DialogClientView button code and unit tests.

Refine DialogClientView button code and unit tests.

Add an escape accelerator to the ok button only if there is *not* a cancel button.
Move FocusManager/ChangeListener cleanup to ViewHierarchyChanged.
Clear ok/cancel/default button pointers on ViewHierarchyChanged removal.

Remove view_unittest MockMenuModel and related use.
( these were left unused by http://crrev.com/87490 )

Move tests and helpers to dialog_delegate_unittest, cleanup.
Merge, cleanup, and add tests, no loss of coverage.

BUG=241451, 166075
TEST=Dialogs with just an [Ok] button will accept on [Esc]; no crashes.
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206950

[msw, 2013-06-17 19:49:27]

Hey Scott, please take a look; thanks!

[sky, 2013-06-17 20:30:14]

https://codereview.chromium.org/17127003/diff/28001/ui/views/window/dialog_cl...
File ui/views/window/dialog_client_view.cc (right):

https://codereview.chromium.org/17127003/diff/28001/ui/views/window/dialog_cl...
ui/views/window/dialog_client_view.cc:80: RemoveChildView(ok_button_);
Is there a particular reason you are adding this? ~View removes from parent.

[msw, 2013-06-17 21:10:55]

Thanks for the tip! Please take another look.

https://codereview.chromium.org/17127003/diff/28001/ui/views/window/dialog_cl...
File ui/views/window/dialog_client_view.cc (right):

https://codereview.chromium.org/17127003/diff/28001/ui/views/window/dialog_cl...
ui/views/window/dialog_client_view.cc:80: RemoveChildView(ok_button_);
On 2013/06/17 20:30:14, sky wrote:
> Is there a particular reason you are adding this? ~View removes from parent.

Ah, solely out of ignorance; updated this and simplified tests.

[sky, 2013-06-17 22:59:30]

LGTM

[commit-bot: I haz the power, 2013-06-17 23:06:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/17127003/38001

[commit-bot: I haz the power, 2013-06-18 12:21:52]

Change committed as 206950