OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h" | 5 #include "chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h" |
6 | 6 |
7 #include "base/compiler_specific.h" | 7 #include "base/compiler_specific.h" |
8 #include "base/message_loop/message_loop.h" | 8 #include "base/run_loop.h" |
9 #include "base/strings/utf_string_conversions.h" | 9 #include "base/strings/utf_string_conversions.h" |
10 #include "chrome/browser/bookmarks/bookmark_model.h" | 10 #include "chrome/browser/bookmarks/bookmark_model.h" |
11 #include "chrome/browser/bookmarks/bookmark_model_factory.h" | 11 #include "chrome/browser/bookmarks/bookmark_model_factory.h" |
12 #include "chrome/browser/ui/browser.h" | 12 #include "chrome/browser/ui/browser.h" |
13 #include "chrome/browser/ui/gtk/tabstrip_origin_provider.h" | 13 #include "chrome/browser/ui/gtk/tabstrip_origin_provider.h" |
14 #include "chrome/test/base/test_browser_window.h" | 14 #include "chrome/test/base/test_browser_window.h" |
15 #include "chrome/test/base/testing_profile.h" | 15 #include "chrome/test/base/testing_profile.h" |
16 #include "chrome/test/base/ui_test_utils.h" | 16 #include "chrome/test/base/ui_test_utils.h" |
17 #include "content/public/test/test_browser_thread.h" | 17 #include "content/public/test/test_browser_thread_bundle.h" |
18 #include "testing/gtest/include/gtest/gtest.h" | 18 #include "testing/gtest/include/gtest/gtest.h" |
19 | 19 |
20 using content::BrowserThread; | |
21 | |
22 // Dummy implementation that's good enough for the tests; we don't test | 20 // Dummy implementation that's good enough for the tests; we don't test |
23 // rendering here so all we need is a non-NULL object. | 21 // rendering here so all we need is a non-NULL object. |
24 class EmptyTabstripOriginProvider : public TabstripOriginProvider { | 22 class EmptyTabstripOriginProvider : public TabstripOriginProvider { |
25 public: | 23 public: |
26 virtual gfx::Point GetTabStripOriginForWidget(GtkWidget* widget) OVERRIDE { | 24 virtual gfx::Point GetTabStripOriginForWidget(GtkWidget* widget) OVERRIDE { |
27 return gfx::Point(0, 0); | 25 return gfx::Point(0, 0); |
28 } | 26 } |
29 }; | 27 }; |
30 | 28 |
31 class BookmarkBarGtkUnittest : public testing::Test { | 29 class BookmarkBarGtkUnittest : public testing::Test { |
32 protected: | 30 protected: |
33 BookmarkBarGtkUnittest() | |
34 : ui_thread_(BrowserThread::UI, &message_loop_), | |
35 file_thread_(BrowserThread::FILE, &message_loop_) { | |
36 } | |
37 | |
38 virtual void SetUp() OVERRIDE { | 31 virtual void SetUp() OVERRIDE { |
39 profile_.reset(new TestingProfile()); | 32 profile_.reset(new TestingProfile()); |
40 profile_->CreateBookmarkModel(true); | 33 profile_->CreateBookmarkModel(true); |
41 model_ = BookmarkModelFactory::GetForProfile(profile_.get()); | 34 model_ = BookmarkModelFactory::GetForProfile(profile_.get()); |
42 ui_test_utils::WaitForBookmarkModelToLoad(model_); | 35 ui_test_utils::WaitForBookmarkModelToLoad(model_); |
43 | 36 |
44 Browser::CreateParams native_params(profile_.get(), | 37 Browser::CreateParams native_params(profile_.get(), |
45 chrome::GetActiveDesktop()); | 38 chrome::GetActiveDesktop()); |
46 browser_.reset( | 39 browser_.reset( |
47 chrome::CreateBrowserWithTestWindowForParams(&native_params)); | 40 chrome::CreateBrowserWithTestWindowForParams(&native_params)); |
48 origin_provider_.reset(new EmptyTabstripOriginProvider); | 41 origin_provider_.reset(new EmptyTabstripOriginProvider); |
49 bookmark_bar_.reset(new BookmarkBarGtk(NULL, browser_.get(), | 42 bookmark_bar_.reset(new BookmarkBarGtk(NULL, browser_.get(), |
50 origin_provider_.get())); | 43 origin_provider_.get())); |
51 } | 44 } |
52 | 45 |
53 virtual void TearDown() OVERRIDE { | 46 virtual void TearDown() OVERRIDE { |
54 message_loop_.RunUntilIdle(); | 47 base::RunLoop().RunUntilIdle(); |
55 | 48 |
56 bookmark_bar_.reset(); | 49 bookmark_bar_.reset(); |
57 origin_provider_.reset(); | 50 origin_provider_.reset(); |
58 browser_.reset(); | 51 browser_.reset(); |
59 profile_.reset(); | 52 profile_.reset(); |
60 } | 53 } |
61 | 54 |
62 BookmarkModel* model_; | 55 BookmarkModel* model_; |
63 | 56 |
64 base::MessageLoopForUI message_loop_; | 57 content::TestBrowserThreadBundle thread_bundle_; |
65 content::TestBrowserThread ui_thread_; | |
66 content::TestBrowserThread file_thread_; | |
67 | 58 |
68 scoped_ptr<TestingProfile> profile_; | 59 scoped_ptr<TestingProfile> profile_; |
69 scoped_ptr<Browser> browser_; | 60 scoped_ptr<Browser> browser_; |
70 scoped_ptr<TabstripOriginProvider> origin_provider_; | 61 scoped_ptr<TabstripOriginProvider> origin_provider_; |
71 scoped_ptr<BookmarkBarGtk> bookmark_bar_; | 62 scoped_ptr<BookmarkBarGtk> bookmark_bar_; |
72 }; | 63 }; |
73 | 64 |
74 TEST_F(BookmarkBarGtkUnittest, DisplaysHelpMessageOnEmpty) { | 65 TEST_F(BookmarkBarGtkUnittest, DisplaysHelpMessageOnEmpty) { |
75 bookmark_bar_->Loaded(model_, false); | 66 bookmark_bar_->Loaded(model_, false); |
76 | 67 |
(...skipping 19 matching lines...) Expand all Loading... |
96 ASCIIToUTF16("other"), GURL("http://two.com")); | 87 ASCIIToUTF16("other"), GURL("http://two.com")); |
97 | 88 |
98 bookmark_bar_->Loaded(model_, false); | 89 bookmark_bar_->Loaded(model_, false); |
99 | 90 |
100 // We should expect two children to the bookmark bar's toolbar. | 91 // We should expect two children to the bookmark bar's toolbar. |
101 GList* children = gtk_container_get_children( | 92 GList* children = gtk_container_get_children( |
102 GTK_CONTAINER(bookmark_bar_->bookmark_toolbar_.get())); | 93 GTK_CONTAINER(bookmark_bar_->bookmark_toolbar_.get())); |
103 EXPECT_EQ(2U, g_list_length(children)); | 94 EXPECT_EQ(2U, g_list_length(children)); |
104 g_list_free(children); | 95 g_list_free(children); |
105 } | 96 } |
OLD | NEW |