Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 17122007: Appease ASAN in Mesa 9.0.3 (Closed)

Created:
7 years, 6 months ago by Myles C. Maxfield (Amazon.com)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, marcheu, Stephen White
Base URL:
https://src.chromium.org/chrome/trunk/deps/
Visibility:
Public.

Description

In _mesa_add_parameter, in prog_parameter.c, |values| represents an array holding a variable number of values. These values get copied out of the array 4 at a time with the COPY_4V macro, however, the array might only contain a single element. In this case, ASAN reports a read-before-initialize because the last 3 of the 4 elements haven't been written to yet. This patch should be upstreamed to Mesa. BUG=238755 NOTRY=true

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/mesa/src/mesa/program/prog_parameter.c View 1 2 3 4 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Myles C. Maxfield (Amazon.com)
7 years, 6 months ago (2013-06-15 02:05:24 UTC) #1
Ken Russell (switch to Gerrit)
Note that this patch should probably be upstreamed to Mesa. I'll try to modify the ...
7 years, 6 months ago (2013-06-17 19:30:22 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-17 19:31:27 UTC) #3
Ken Russell (switch to Gerrit)
Oops. LGTM
7 years, 6 months ago (2013-06-17 19:32:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mymax@amazon.com/17122007/13001
7 years, 6 months ago (2013-06-17 19:32:40 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 19:33:05 UTC) #6
Message was sent while issue was closed.
Change committed as 206770

Powered by Google App Engine
This is Rietveld 408576698