Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17121007: Cleanup in CSSGrammar.y.in (Closed)

Created:
7 years, 6 months ago by SeRya
Modified:
7 years, 6 months ago
Reviewers:
apavlov, Eric Willigers
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Visibility:
Public.

Description

Cleanup in CSSGrammar.y.in Removed lines like "$$ = $1;" because $$ is $1 by default. Removed always-true conditions. Removed trailing whitespaces. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152942

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -61 lines) Patch
M Source/core/css/CSSGrammar.y.in View 1 2 3 18 chunks +34 lines, -61 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
SeRya
7 years, 6 months ago (2013-06-17 18:35:43 UTC) #1
SeRya
7 years, 6 months ago (2013-06-17 18:35:53 UTC) #2
SeRya
7 years, 6 months ago (2013-06-18 08:38:05 UTC) #3
SeRya
7 years, 6 months ago (2013-06-19 13:55:54 UTC) #4
apavlov
https://codereview.chromium.org/17121007/diff/7001/Source/core/css/CSSGrammar.y.in File Source/core/css/CSSGrammar.y.in (right): https://codereview.chromium.org/17121007/diff/7001/Source/core/css/CSSGrammar.y.in#newcode475 Source/core/css/CSSGrammar.y.in:475: $$ = 1; $1, not 1 https://codereview.chromium.org/17121007/diff/7001/Source/core/css/CSSGrammar.y.in#newcode664 Source/core/css/CSSGrammar.y.in:664: $$ ...
7 years, 6 months ago (2013-06-19 14:02:19 UTC) #5
SeRya
https://codereview.chromium.org/17121007/diff/7001/Source/core/css/CSSGrammar.y.in File Source/core/css/CSSGrammar.y.in (right): https://codereview.chromium.org/17121007/diff/7001/Source/core/css/CSSGrammar.y.in#newcode475 Source/core/css/CSSGrammar.y.in:475: $$ = 1; On 2013/06/19 14:02:19, apavlov wrote: > ...
7 years, 6 months ago (2013-06-19 14:07:01 UTC) #6
apavlov
LGTM with nits https://codereview.chromium.org/17121007/diff/14002/Source/core/css/CSSGrammar.y.in File Source/core/css/CSSGrammar.y.in (left): https://codereview.chromium.org/17121007/diff/14002/Source/core/css/CSSGrammar.y.in#oldcode494 Source/core/css/CSSGrammar.y.in:494: $$ = $1; This is not ...
7 years, 6 months ago (2013-06-19 14:12:34 UTC) #7
Eric Willigers
lgtm
7 years, 6 months ago (2013-06-21 01:13:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/17121007/21001
7 years, 6 months ago (2013-06-24 08:54:07 UTC) #9
SeRya
https://codereview.chromium.org/17121007/diff/14002/Source/core/css/CSSGrammar.y.in File Source/core/css/CSSGrammar.y.in (left): https://codereview.chromium.org/17121007/diff/14002/Source/core/css/CSSGrammar.y.in#oldcode494 Source/core/css/CSSGrammar.y.in:494: $$ = $1; On 2013/06/19 14:12:35, apavlov wrote: > ...
7 years, 6 months ago (2013-06-24 08:54:15 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 10:36:53 UTC) #11
Message was sent while issue was closed. 
Change committed as 152942

Powered by Google App Engine
This is Rietveld 408576698