[Android] Refactor the buildbot scripts to prepare for downstream usage.

build/android/buildbot/bb_utils.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import optparse
 import os
 import pipes
 import subprocess
 import sys
@@ skipping 60 matching lines @@
                     callback=ConvertJson, type='string', default={},
                     help='factory properties in JSON format')
   return parser
 
 
 def EncodeProperties(options):
   return ['--factory-properties=%s' % json.dumps(options.factory_properties),
           '--build-properties=%s' % json.dumps(options.build_properties)]
 
 
-def RunSteps(all_steps, options):
-  if not options.steps:
-    return
-
-  steps = options.steps.split(',')
-  unknown_steps = set(steps) - set(step for step, _ in all_steps)
+def RunSteps(steps, step_cmds, options):
+  unknown_steps = set(steps) - set(step for step, _ in step_cmds)
   if unknown_steps:
     print >> sys.stderr, 'FATAL: Unknown steps %s' % list(unknown_steps)
     sys.exit(1)
 
-  for step, cmd in all_steps:
+  for step, cmd in step_cmds:
     if step in steps:
       cmd(options)
+
+
+def RunAllSteps(step_cmds, options):

[Isaac (away), 2013/06/29 09:55:39]

I think this would be better to keep this code inline and not make a function.

[Siva Chandra, 2013/07/01 23:58:53]

Done.

+  for _, cmd in step_cmds:
+    cmd(options)