Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/history/top_sites.cc

Issue 17114002: Field trial removing tiles from NTP if URL is already open - for 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments plus rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/top_sites.cc
diff --git a/chrome/browser/history/top_sites.cc b/chrome/browser/history/top_sites.cc
index 9de804e1f34059a89f8c8395b4aaa211dcafddda..b1f947dc0d1790e30a822a262b6012bc0ac5a6fb 100644
--- a/chrome/browser/history/top_sites.cc
+++ b/chrome/browser/history/top_sites.cc
@@ -15,21 +15,6 @@
namespace history {
-namespace {
-
-// Constants for the most visited tile placement field trial.
-// ex:
-// "OneEightGroup_Flipped" --> Will cause tile 1 and 8 to be flipped.
-// "OneEightGroup_NoChange" --> Will not flip anything.
-//
-// See field trial config (MostVisitedTilePlacement.json) for details.
-const char kMostVisitedFieldTrialName[] = "MostVisitedTilePlacement";
-const char kOneEightGroupPrefix[] = "OneEight";
-const char kOneFourGroupPrefix[] = "OneFour";
-const char kFlippedSuffix[] = "Flipped";
-
-} // namespace
-
const TopSites::PrepopulatedPage kPrepopulatedPages[] = {
#if defined(OS_ANDROID)
{ IDS_MOBILE_WELCOME_URL, IDS_NEW_TAB_CHROME_WELCOME_PAGE_TITLE,
@@ -60,27 +45,4 @@ TopSites* TopSites::Create(Profile* profile, const base::FilePath& db_name) {
return top_sites_impl;
}
-// static
-void TopSites::MaybeShuffle(MostVisitedURLList* data) {
- const std::string group_name =
- base::FieldTrialList::FindFullName(kMostVisitedFieldTrialName);
-
- // Depending on the study group of the client, we might flip the 1st and 4th
- // tiles, or the 1st and 8th, or do nothing.
- if (EndsWith(group_name, kFlippedSuffix, true)) {
- size_t index_to_flip = 0;
- if (StartsWithASCII(group_name, kOneEightGroupPrefix, true) &&
- data->size() >= 8) {
- index_to_flip = 7;
- } else if (StartsWithASCII(group_name, kOneFourGroupPrefix, true) &&
- data->size() >= 4) {
- index_to_flip = 3;
- }
-
- if (data->empty() || (*data)[index_to_flip].url.is_empty())
- return;
- std::swap((*data)[0], (*data)[index_to_flip]);
- }
-}
-
} // namespace history

Powered by Google App Engine
This is Rietveld 408576698