Field trial removing tiles from NTP if URL is already open - for 1993 clients

chrome/browser/history/top_sites.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/top_sites.h"
 
 #include "base/metrics/field_trial.h"
+#include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
+#include "base/values.h"
 #include "chrome/browser/history/top_sites_impl.h"
 #include "chrome/browser/history/top_sites_likely_impl.h"
+#include "chrome/common/instant_types.h"
+#include "content/public/browser/web_contents.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/theme_resources.h"
 
 namespace history {
 
 namespace {
 
 // Constants for the most visited tile placement field trial.
 // ex:
 // "OneEightGroup_Flipped" --> Will cause tile 1 and 8 to be flipped.
 // "OneEightGroup_NoChange" --> Will not flip anything.
 //
 // See field trial config (MostVisitedTilePlacement.json) for details.
 const char kMostVisitedFieldTrialName[] = "MostVisitedTilePlacement";
 const char kOneEightGroupPrefix[] = "OneEight";
 const char kOneFourGroupPrefix[] = "OneFour";
 const char kFlippedSuffix[] = "Flipped";
+const char kTabsGroupName[] = "DontShowOpenTabs";
+
+// Minimum number of Most Visited suggestions required in order for the Most
+// Visited Field Trial to remove a URL already open in the browser.
+const size_t kMinUrlSuggestions = 8;
 
 }  // namespace
 
 const TopSites::PrepopulatedPage kPrepopulatedPages[] = {
 #if defined(OS_ANDROID)
     { IDS_MOBILE_WELCOME_URL, IDS_NEW_TAB_CHROME_WELCOME_PAGE_TITLE,
     IDR_PRODUCT_LOGO_16, IDR_NEWTAB_CHROME_WELCOME_PAGE_THUMBNAIL,
     SkColorSetRGB(0, 147, 60) }
 #else
   { IDS_CHROME_WELCOME_URL, IDS_NEW_TAB_CHROME_WELCOME_PAGE_TITLE,
@@ skipping 22 matching lines @@
 
 // static
 void TopSites::MaybeShuffle(MostVisitedURLList* data) {
   const std::string group_name =
       base::FieldTrialList::FindFullName(kMostVisitedFieldTrialName);
 
   // Depending on the study group of the client, we might flip the 1st and 4th
   // tiles, or the 1st and 8th, or do nothing.
   if (EndsWith(group_name, kFlippedSuffix, true)) {
     size_t index_to_flip = 0;
-    if (StartsWithASCII(group_name, kOneEightGroupPrefix, true) &&
-        data->size() >= 8) {
-      index_to_flip = 7;
-    } else if (StartsWithASCII(group_name, kOneFourGroupPrefix, true) &&
-               data->size() >= 4) {
-      index_to_flip = 3;
+    if (StartsWithASCII(group_name, kOneEightGroupPrefix, true)) {
+      if (data->size() < 8) {
+        LogInHistogram(NTP_TILE_EXPERIMENT_ACTION_TOO_FEW_URLS_TILES_1_8);
+      } else {
+        index_to_flip = 7;
+      }
+    } else if (StartsWithASCII(group_name, kOneFourGroupPrefix, true)) {
+      if (data->size() < 4) {
+        LogInHistogram(NTP_TILE_EXPERIMENT_ACTION_TOO_FEW_URLS_TILES_1_4);
+      } else {
+        index_to_flip = 3;
+      }
     }
 
-    if (data->empty() || (*data)[index_to_flip].url.is_empty())
+    if (data->empty() || (*data)[index_to_flip].url.is_empty()) {
+      LogInHistogram(NTP_TILE_EXPERIMENT_ACTION_NO_URL_TO_FLIP);
       return;
+    }
     std::swap((*data)[0], (*data)[index_to_flip]);
   }
 }
 
+// static
+bool TopSites::IsClientInTabsGroup() {
+  return base::FieldTrialList::FindFullName(kMostVisitedFieldTrialName) ==
+      kTabsGroupName;
+}
+
+// static
+void TopSites::RemoveItemsMatchingOpenTabs(
+    const std::set<std::string>& open_urls,
+    std::vector<InstantMostVisitedItem>* items) {
+  size_t i = 0;
+  while (i < items->size()) {
+    const std::string url = (*items)[i].url.spec();

[sky, 2013/07/16 21:15:07]

const std::string&

[annark1, 2013/07/17 17:45:52]

Done.

+    if (open_urls.count(url) != 0) {
+      if (items->size() <= kMinUrlSuggestions) {
+        UMA_HISTOGRAM_ENUMERATION(
+            "NewTabPage.MostVisitedTilePlacementExperiment",
+            NTP_TILE_EXPERIMENT_ACTION_DID_NOT_REMOVE_URL,
+            NUM_NTP_TILE_EXPERIMENT_ACTIONS);
+        ++i;
+      } else {
+        items->erase(items->begin()+i);

[sky, 2013/07/16 21:15:07]

use spaces

[annark1, 2013/07/17 17:45:52]

Done.

+        UMA_HISTOGRAM_ENUMERATION(
+            "NewTabPage.MostVisitedTilePlacementExperiment",
+            NTP_TILE_EXPERIMENT_ACTION_REMOVED_URL,
+            NUM_NTP_TILE_EXPERIMENT_ACTIONS);
+      }
+    } else {
+      ++i;
+    }
+  }
+}
+
+// static
+void TopSites::RemovePageValuesMatchingOpenTabs(

[sky, 2013/07/16 21:15:07]

Can't we implement one of these in terms of the other?

[annark1, 2013/07/17 17:45:52]

I've discussed with Phillippe, and given the fact that they don't share an
interface, we don't see how I can do that.

On 2013/07/16 21:15:07, sky wrote:

+    const std::set<std::string>& open_urls,
+    base::ListValue* pages_value) {
+  size_t i = 0;
+  while (i < pages_value->GetSize()) {
+    base::DictionaryValue* page_value;
+    std::string url;
+    if (pages_value->GetDictionary(i, &page_value) &&
+        page_value->GetString("url", &url) &&
+        open_urls.count(url) != 0) {
+      if (pages_value->GetSize() <= kMinUrlSuggestions) {
+        UMA_HISTOGRAM_ENUMERATION(
+            "NewTabPage.MostVisitedTilePlacementExperiment",
+            NTP_TILE_EXPERIMENT_ACTION_DID_NOT_REMOVE_URL,
+            NUM_NTP_TILE_EXPERIMENT_ACTIONS);
+        ++i;
+      } else {
+        pages_value->Remove(*page_value, &i);
+        UMA_HISTOGRAM_ENUMERATION(
+            "NewTabPage.MostVisitedTilePlacementExperiment",
+            NTP_TILE_EXPERIMENT_ACTION_REMOVED_URL,
+            NUM_NTP_TILE_EXPERIMENT_ACTIONS);
+      }
+    } else {
+      ++i;
+    }
+  }
+}
+
+// static
+void TopSites::LogInHistogram(NtpTileExperimentActions action) {
+  UMA_HISTOGRAM_ENUMERATION(
+              "NewTabPage.MostVisitedTilePlacementExperiment",
+              action,
+              NUM_NTP_TILE_EXPERIMENT_ACTIONS);
+}
+
 }  // namespace history