Issue 17112022: Remove source line tracking from MediaList and related DevTools code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17112022: Remove source line tracking from MediaList and related DevTools code (Closed)

Created:
7 years, 6 months ago by apavlov

Modified:
7 years, 6 months ago

Reviewers:
vsevik, pfeldman, yurys

CC:
blink-reviews, kenneth.christiansen, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove source line tracking from MediaList and related DevTools code Now that the DevTools can track the source range related to CSSMedia, MediaList::m_sourceLine and CSS.CSSMedia.sourceLine are no longer needed. R=pfeldman, vsevik, yurys@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152716

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -18 lines)			Patch
M	Source/core/css/CSSGrammar.y.in	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/css/CSSParser.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSParser.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/css/MediaList.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/css/MediaList.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/CSSStyleModel.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/protocol.json	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/17112022/1

7 years, 6 months ago (2013-06-19 10:01:40 UTC) #3

Message was sent while issue was closed.

Change committed as 152716

Expand Messages | Collapse Messages