Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 17112017: Invert the dialog background color for Windows high contrast. (Closed)

Created:
7 years, 6 months ago by msw
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, dmazzoni
Visibility:
Public.

Description

Invert the dialog background color for Windows high contrast. Invert the hardcoded kColorId_DialogBackground as needed. See before/after pics at http://crbug.com/234681#c7 (note that I'm addressing the new button style separately) BUG=234681, 166075 TEST=Dialogs are legible in Windows high contrast themes. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/native_theme/native_theme_win.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 6 months ago (2013-06-19 01:37:56 UTC) #1
sky
LGTM
7 years, 6 months ago (2013-06-19 04:00:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/17112017/1
7 years, 6 months ago (2013-06-19 04:18:12 UTC) #3
Peter Kasting
It's sort of weird that we simplify the world down to "inverted color scheme or ...
7 years, 6 months ago (2013-06-19 05:21:01 UTC) #4
Peter Kasting
On 2013/06/19 05:21:01, Peter Kasting wrote: > It's sort of weird that we simplify the ...
7 years, 6 months ago (2013-06-19 05:26:29 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-19 10:40:45 UTC) #6
Message was sent while issue was closed.
Change committed as 207209

Powered by Google App Engine
This is Rietveld 408576698