Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 1710853002: android: Add a method to let Java know whether a prerender has finished loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
index 5fcec5db02908136a8cb2c31b35643c0db31b090..ee6096da7919791e4fa0a8b0523be4577db0ef1e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
@@ -77,7 +77,8 @@ public class CustomTabsConnection extends ICustomTabsService.Stub {
private static AtomicReference<CustomTabsConnection> sInstance =
new AtomicReference<CustomTabsConnection>();
- private static final class PrerenderedUrlParams {
+ @VisibleForTesting
+ static final class PrerenderedUrlParams {
public final IBinder mSession;
public final WebContents mWebContents;
public final String mUrl;
@@ -99,7 +100,8 @@ public class CustomTabsConnection extends ICustomTabsService.Stub {
private final AtomicBoolean mWarmupHasBeenCalled = new AtomicBoolean();
private final ClientManager mClientManager;
private ExternalPrerenderHandler mExternalPrerenderHandler;
- private PrerenderedUrlParams mPrerender;
+ @VisibleForTesting
+ PrerenderedUrlParams mPrerender;
gone 2016/02/22 18:50:15 Move up a line; I think package protected variable
Benoit L 2016/02/25 16:03:21 Done.
private WebContents mSpareWebContents;
/**

Powered by Google App Engine
This is Rietveld 408576698