Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 17108012: Android: adds test intents for memory pressure. (Closed)

Created:
7 years, 6 months ago by bulach
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Android: adds test intents for memory pressure. Allows using: adb shell am start -a org.chromium.content_shell.action.ACTION_LOW_MEMORY \ -n org.chromium.content_shell_apk/.ContentShellActivity to simulate memory pressure signals. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207960

Patch Set 1 #

Total comments: 6

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M base/android/java/src/org/chromium/base/MemoryPressureListener.java View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java View 1 3 chunks +22 lines, -0 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 1 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bulach
ptal
7 years, 6 months ago (2013-06-17 17:28:26 UTC) #1
rmcilroy
https://codereview.chromium.org/17108012/diff/1/base/android/java/src/org/chromium/base/MemoryPressureListener.java File base/android/java/src/org/chromium/base/MemoryPressureListener.java (right): https://codereview.chromium.org/17108012/diff/1/base/android/java/src/org/chromium/base/MemoryPressureListener.java#newcode19 base/android/java/src/org/chromium/base/MemoryPressureListener.java:19: public class MemoryPressureListener { Does this need to be ...
7 years, 6 months ago (2013-06-17 18:22:43 UTC) #2
bulach
thanks ross! all addressed, ptal https://codereview.chromium.org/17108012/diff/1/base/android/java/src/org/chromium/base/MemoryPressureListener.java File base/android/java/src/org/chromium/base/MemoryPressureListener.java (right): https://codereview.chromium.org/17108012/diff/1/base/android/java/src/org/chromium/base/MemoryPressureListener.java#newcode19 base/android/java/src/org/chromium/base/MemoryPressureListener.java:19: public class MemoryPressureListener { ...
7 years, 6 months ago (2013-06-18 09:08:55 UTC) #3
rmcilroy
lgtm Thanks Marcus.
7 years, 6 months ago (2013-06-18 11:14:58 UTC) #4
bulach
+yfriedman for content/shell/android OWNERS
7 years, 6 months ago (2013-06-19 09:37:25 UTC) #5
bulach
ping? :)
7 years, 6 months ago (2013-06-21 13:36:24 UTC) #6
Yaron
lgtm Sorry didn't see this before
7 years, 6 months ago (2013-06-21 17:01:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/17108012/7001
7 years, 6 months ago (2013-06-21 17:46:35 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 23:50:16 UTC) #9
Message was sent while issue was closed.
Change committed as 207960

Powered by Google App Engine
This is Rietveld 408576698