Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 17103007: adb_gdb: Minor improvements (Closed)

Created:
7 years, 6 months ago by digit1
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

adb_gdb: Minor improvements This patch improves the Android-specific adb_gdb debugging scripts in several minor ways: - It ensures that the temporary directory is always removed when the script exits, even whe it is interrupted with Ctrl-C. - It ensures that if --pull-libs is interrupted by a Ctrl-C, the build.prop in /tmp/$USER-adb-gdb-libs/ is erased, forcing a --pull-libs operation in the next invokation, instead of keeping a portion of the libraries in a bad state. - It adds a --su-prefix=<prefix> option, to be able to use tools like 'su' on rooted production devices. This is useful when the installed app is not debuggable (e.g. a release build), and there is no way to run ADB as root. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206990

Patch Set 1 #

Patch Set 2 : Handle bad --su-prefix that actually don't give root rights. #

Patch Set 3 : Re-enable --su-prefix check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -14 lines) Patch
M build/android/adb_gdb View 1 2 6 chunks +46 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
digit1
7 years, 6 months ago (2013-06-18 07:59:03 UTC) #1
digit1
Second patch handles bad --su-prefix values like "echo" that do work as a command prefix, ...
7 years, 6 months ago (2013-06-18 08:27:10 UTC) #2
digit1
For context, these changes came out as useful during Benjamin's debugging of Samsumg S4 - ...
7 years, 6 months ago (2013-06-18 08:28:02 UTC) #3
qsr
lgtm
7 years, 6 months ago (2013-06-18 08:31:55 UTC) #4
bulach
lgtm
7 years, 6 months ago (2013-06-18 08:53:19 UTC) #5
Philippe
lgtm, thanks David!
7 years, 6 months ago (2013-06-18 09:52:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/17103007/3
7 years, 6 months ago (2013-06-18 10:37:16 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 14:24:47 UTC) #8
Message was sent while issue was closed.
Change committed as 206990

Powered by Google App Engine
This is Rietveld 408576698