Issue 17101035: Web MIDI: refine MIDIAccessor and WebMIDIAccessor APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17101035: Web MIDI: refine MIDIAccessor and WebMIDIAccessor APIs (Closed)

Created:
7 years, 6 months ago by Chris Rogers

Modified:
7 years, 6 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, eae+blinkwatch, jeez, jamesr, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Web MIDI: refine MIDIAccessor and WebMIDIAccessor APIs This re-lands 17155009 along with Adam Barth's last review comments. https://codereview.chromium.org/17155009/#msg12 TEST=(tested locally with unlanded Chromium back-end) BUG=163795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152780

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -28 lines)			Patch
M	Source/core/platform/midi/MIDIAccessor.h	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	Source/core/platform/midi/MIDIAccessor.cpp	View	2 chunks	+14 lines, -9 lines	0 comments	Download
M	Source/core/platform/midi/MIDIAccessorClient.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	public/platform/Platform.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	public/platform/WebMIDIAccessor.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	public/platform/WebMIDIAccessorClient.h	View	1 chunk	+7 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

abarth-chromium

LGTM Please add some more information to your description that explains why you're making this ...

7 years, 6 months ago (2013-06-20 01:44:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/17101035/1

7 years, 6 months ago (2013-06-20 02:06:41 UTC) #3

Message was sent while issue was closed.

Change committed as 152780