Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17101020: Support cancellation of non-yet-running jobs in drive::JobScheduler. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Support cancellation of non-yet-running jobs in drive::JobScheduler. BUG=251116 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207824

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebase + review fix. #

Patch Set 3 : Fix failures in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -7 lines) Patch
M chrome/browser/chromeos/drive/job_queue.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_queue.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_queue_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 2 22 chunks +62 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
7 years, 6 months ago (2013-06-20 01:11:37 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/17101020/diff/5001/chrome/browser/chromeos/drive/job_scheduler.h File chrome/browser/chromeos/drive/job_scheduler.h (right): https://codereview.chromium.org/17101020/diff/5001/chrome/browser/chromeos/drive/job_scheduler.h#newcode214 chrome/browser/chromeos/drive/job_scheduler.h:214: base::Callback<void(google_apis::GDataErrorCode)> abort; nit: Can we make this variable's ...
7 years, 6 months ago (2013-06-20 03:51:54 UTC) #2
kinaba
https://codereview.chromium.org/17101020/diff/5001/chrome/browser/chromeos/drive/job_scheduler.h File chrome/browser/chromeos/drive/job_scheduler.h (right): https://codereview.chromium.org/17101020/diff/5001/chrome/browser/chromeos/drive/job_scheduler.h#newcode214 chrome/browser/chromeos/drive/job_scheduler.h:214: base::Callback<void(google_apis::GDataErrorCode)> abort; On 2013/06/20 03:51:54, hashimoto wrote: > nit: ...
7 years, 6 months ago (2013-06-21 01:59:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17101020/10001
7 years, 6 months ago (2013-06-21 02:00:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=128498
7 years, 6 months ago (2013-06-21 03:01:01 UTC) #5
kinaba
On 2013/06/21 03:01:01, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 6 months ago (2013-06-21 03:46:15 UTC) #6
kinaba
Fixed. Could you kindly take a look once again?
7 years, 6 months ago (2013-06-21 04:47:18 UTC) #7
hashimoto
lgtm
7 years, 6 months ago (2013-06-21 04:56:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17101020/31001
7 years, 6 months ago (2013-06-21 04:58:23 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 15:23:22 UTC) #10
Message was sent while issue was closed. 
Change committed as 207824

Powered by Google App Engine
This is Rietveld 408576698