Rename SkDrawCommand subclasses

Rename SkDrawCommand subclasses

SkDrawCommand subclass names are too generic and likely to clash in the default namespace.
This makes the header unusable in Chrome - for example, on Mac builders:

../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment'
class Comment : public SkDrawCommand {
	      ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here
struct Comment {


This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command".

R=robertphillips@google.com,reed@google.com

Committed: http://code.google.com/p/skia/source/detail?r=9667

[f(malita), 2013-06-18 18:19:28]

Ping - this is blocking https://codereview.chromium.org/15967010/.

[reed1, 2013-06-18 18:29:43]

removing self from reviewer list (out of total ignorance).

Reviewers: please review!

[robertphillips, 2013-06-18 19:36:29]

lgtm + nits

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDebug...
File src/utils/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDebug...
src/utils/debugger/SkDebugCanvas.cpp:386: addDrawCommand(new
SkDrawVerticesCommand(vmode, vertexCount, vertices,
please indent the following line to match the prior one.

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
File src/utils/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:285:
SkDrawBitmapMatrixCommand::SkDrawBitmapMatrixCommand(const SkBitmap& bitmap,
please fix indent in following lines

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:314:
SkDrawBitmapNineCommand::SkDrawBitmapNineCommand(const SkBitmap& bitmap, const
SkIRect& center,
here too

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:344:
SkDrawBitmapRectCommand::SkDrawBitmapRectCommand(const SkBitmap& bitmap, const
SkRect* src,
here too

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:491:
SkDrawPointsCommand::SkDrawPointsCommand(SkCanvas::PointMode mode, size_t count,
here too

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:534:
SkDrawPosTextCommand::SkDrawPosTextCommand(const void* text, size_t byteLength,
const SkPoint pos[],
same

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:559:
SkDrawPosTextHCommand::SkDrawPosTextHCommand(const void* text, size_t
byteLength,
same

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:616:
SkDrawSpriteCommand::SkDrawSpriteCommand(const SkBitmap& bitmap, int left, int
top,
same

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:646:
SkDrawTextCommand::SkDrawTextCommand(const void* text, size_t byteLength,
SkScalar x, SkScalar y,
same

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:666:
SkDrawTextOnPathCommand::SkDrawTextOnPathCommand(const void* text, size_t
byteLength,
same

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:695:
SkDrawVerticesCommand::SkDrawVerticesCommand(SkCanvas::VertexMode vmode, int
vertexCount,
same

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.cpp:794:
SkSaveLayerCommand::SkSaveLayerCommand(const SkRect* bounds, const SkPaint*
paint,
same

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
File src/utils/debugger/SkDrawCommand.h (right):

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.h:354: SkDrawPosTextCommand(const void* text,
size_t byteLength, const SkPoint pos[],
please indent the following line to match the prior one.

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.h:369: SkDrawTextOnPathCommand(const void*
text, size_t byteLength, const SkPath& path,
same here

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.h:385: SkDrawPosTextHCommand(const void* text,
size_t byteLength, const SkScalar xpos[],
and here

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.h:442:
SkDrawVerticesCommand(SkCanvas::VertexMode vmode, int vertexCount,
and here

https://codereview.chromium.org/17101005/diff/3001/src/utils/debugger/SkDrawC...
src/utils/debugger/SkDrawCommand.h:486: SkSaveLayerCommand(const SkRect* bounds,
const SkPaint* paint,
and here

[f(malita), 2013-06-18 19:43:24]

On 2013/06/18 19:36:29, robertphillips wrote:
> lgtm + nits
> 

Thanks Rob, will do.

[commit-bot: I haz the power, 2013-06-18 20:09:32]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/17101005/14001

[commit-bot: I haz the power, 2013-06-18 20:20:58]

Change committed as 9667