Validate saved credit card number in interactive autocomplete

Validate saved credit card number in interactive autocomplete

If a user saved an invalid credit card number in
chrome://settings/autofillEditCreditCard, then interactive autocomplete
should prompt for a valid credit card number before submitting a form.

BUG=247205
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207724

[please use gerrit instead, 2013-06-14 21:28:20]

Evan: PTAL.

[Evan Stade, 2013-06-14 22:29:49]

https://codereview.chromium.org/17099006/diff/2003/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/data_model_wrapper.cc (right):

https://codereview.chromium.org/17099006/diff/2003/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/data_model_wrapper.cc:143: if
(!autofill::IsValidCreditCardExpirationDate(
I feel like this should be a function on card_

https://codereview.chromium.org/17099006/diff/2003/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/data_model_wrapper.cc:182: if
(!address_->is_complete_address() ||
like this, sort of. (you also need to do validation checks here it would seem)

[please use gerrit instead, 2013-06-17 18:35:42]

Evan: PTAL.

https://codereview.chromium.org/17099006/diff/2003/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/data_model_wrapper.cc (right):

https://codereview.chromium.org/17099006/diff/2003/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/data_model_wrapper.cc:143: if
(!autofill::IsValidCreditCardExpirationDate(
On 2013/06/14 22:29:49, Evan Stade wrote:
> I feel like this should be a function on card_

Done.

https://codereview.chromium.org/17099006/diff/2003/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/data_model_wrapper.cc:182: if
(!address_->is_complete_address() ||
On 2013/06/14 22:29:49, Evan Stade wrote:
> (you also need to do validation checks here it would seem)

I'm working on that in a separate CL. (Small CLs are best CLs!)

[Evan Stade, 2013-06-17 19:17:57]

https://codereview.chromium.org/17099006/diff/32001/components/autofill/brows...
File components/autofill/browser/credit_card.cc (right):

https://codereview.chromium.org/17099006/diff/32001/components/autofill/brows...
components/autofill/browser/credit_card.cc:591: Expiration4DigitYearAsString(),
nit: I would rather not make this depend on IsComplete.

I also don't think it makes sense to convert dates to a string just so they can
immediately be converted back to numerical values. So I'd recommend adding
another function to validation.cc

[please use gerrit instead, 2013-06-17 21:40:23]

Evan: PTAL.

https://codereview.chromium.org/17099006/diff/32001/components/autofill/brows...
File components/autofill/browser/credit_card.cc (right):

https://codereview.chromium.org/17099006/diff/32001/components/autofill/brows...
components/autofill/browser/credit_card.cc:591: Expiration4DigitYearAsString(),
On 2013/06/17 19:17:57, Evan Stade wrote:
> nit: I would rather not make this depend on IsComplete.
> 
> I also don't think it makes sense to convert dates to a string just so they
can
> immediately be converted back to numerical values. So I'd recommend adding
> another function to validation.cc

Done.

[Evan Stade, 2013-06-19 00:38:43]

lgtm

[commit-bot: I haz the power, 2013-06-19 17:16:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/17099006/70001

[commit-bot: I haz the power, 2013-06-19 17:21:39]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-06-19 18:13:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/17099006/70001

[commit-bot: I haz the power, 2013-06-19 18:20:02]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-06-19 18:29:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/17099006/99001

[commit-bot: I haz the power, 2013-06-19 18:41:15]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-06-20 15:56:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/17099006/99001

[commit-bot: I haz the power, 2013-06-20 15:56:16]

Failed to apply patch for components/autofill/browser/credit_card.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: components/autofill/browser/credit_card.cc
  |diff --git a/components/autofill/browser/credit_card.cc
b/components/autofill/browser/credit_card.cc
  |index
2f5417fc2e0fd036c8edbd1750ddab9667cc8b9b..bac2c5a89740fd99bb0d6c0227fbe825c9448cfc
100644
  |--- a/components/autofill/browser/credit_card.cc
  |+++ b/components/autofill/browser/credit_card.cc
  --------------------------
  No file to patch.  Skipping patch.
  2 out of 2 hunks ignored

Patch:       components/autofill/browser/credit_card.cc
Index: components/autofill/browser/credit_card.cc
diff --git a/components/autofill/browser/credit_card.cc
b/components/autofill/browser/credit_card.cc
index
2f5417fc2e0fd036c8edbd1750ddab9667cc8b9b..bac2c5a89740fd99bb0d6c0227fbe825c9448cfc
100644
--- a/components/autofill/browser/credit_card.cc
+++ b/components/autofill/browser/credit_card.cc
@@ -17,6 +17,7 @@
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time.h"
 #include "components/autofill/browser/autofill_field.h"
 #include "components/autofill/browser/autofill_regexes.h"
 #include "components/autofill/browser/autofill_type.h"
@@ -586,6 +587,12 @@ bool CreditCard::IsComplete() const {
       expiration_year_ != 0;
 }
 
+bool CreditCard::IsValid() const {
+  return autofill::IsValidCreditCardNumber(number_) &&
+         autofill::IsValidCreditCardExpirationDate(
+             expiration_year_, expiration_month_, base::Time::Now());
+}
+
 void CreditCard::GetSupportedTypes(FieldTypeSet* supported_types) const {
   supported_types->insert(CREDIT_CARD_NAME);
   supported_types->insert(CREDIT_CARD_NUMBER);

[commit-bot: I haz the power, 2013-06-20 19:22:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/17099006/39002

[commit-bot: I haz the power, 2013-06-21 05:53:25]

Change committed as 207724