Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 17095008: Fix the bug that crashed apps are missing from Apps Developer Tool (Closed)

Created:
7 years, 6 months ago by 方觉(Fang Jue)
Modified:
7 years, 6 months ago
Reviewers:
Gaurav, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix the bug that crashed apps are missing from Apps Developer Tool Crashed apps are not listed in Apps Developer Tool because of a mismatch of argument order when calling setTerminatedReloadLink_. Also fix setTerminatedReloadLink_ to add event listener instead of calling chrome.developerPrivate.reload. BUG=251912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/resources/apps_debugger/js/items_list.js View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
方觉(Fang Jue)
7 years, 6 months ago (2013-06-21 09:46:30 UTC) #1
Dan Beam
+grv@
7 years, 6 months ago (2013-06-21 20:36:59 UTC) #2
Gaurav
On 2013/06/21 20:36:59, Dan Beam wrote: > +grv@ @dbeam: can you give an lgtm (I ...
7 years, 6 months ago (2013-06-21 20:59:59 UTC) #3
Dan Beam
rs lgtm
7 years, 6 months ago (2013-06-21 22:16:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/17095008/1
7 years, 6 months ago (2013-06-21 22:57:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=167960
7 years, 6 months ago (2013-06-22 02:06:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/17095008/1
7 years, 6 months ago (2013-06-22 02:07:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/17095008/1
7 years, 6 months ago (2013-06-22 02:35:03 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=141895
7 years, 6 months ago (2013-06-22 03:13:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/17095008/1
7 years, 6 months ago (2013-06-22 10:41:12 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 13:37:29 UTC) #11
Message was sent while issue was closed.
Change committed as 208017

Powered by Google App Engine
This is Rietveld 408576698