Create sdcard image for emulator.

Create sdcard image for emulator.

The emulator bot currently fails when waiting for the sdcard. The emulator does
not fail when the emulator has an sdcard image present. This CL creates and adds
the sdcard image for emulators.

TBR=cmp@chromium.org
BUG=164911
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207760

[gkanwar, 2013-06-21 01:06:05]

On 2013/06/21 01:01:14, navabi wrote:

It looks like you're using the mksdcard tool after creating the emulator. Is
there a reason you're not just specifying the --sdcard flag to the 'android'
tool when creating the AVD in the first place? I think the code for that is in
pylib/utils/emulator.py.

[navabi, 2013-06-21 01:13:41]

On 2013/06/21 01:06:05, gkanwar wrote:
> On 2013/06/21 01:01:14, navabi wrote:
> 
> It looks like you're using the mksdcard tool after creating the emulator. Is
> there a reason you're not just specifying the --sdcard flag to the 'android'
> tool when creating the AVD in the first place? I think the code for that is in
> pylib/utils/emulator.py.

Good point! Thanks gkanwar. emulator.py was not using the command line option to
create sdcard. Now it is. Thanks.

[gkanwar, 2013-06-21 01:20:00]

https://codereview.chromium.org/17094019/diff/5001/build/android/pylib/utils/...
File build/android/pylib/utils/emulator.py (right):

https://codereview.chromium.org/17094019/diff/5001/build/android/pylib/utils/...
build/android/pylib/utils/emulator.py:205: '--sdcard', '512M',
It probably makes sense to make this value a constant (like API_TARGET above) so
that we can tweak this if needed in the future.

[navabi, 2013-06-21 01:30:08]

https://codereview.chromium.org/17094019/diff/5001/build/android/pylib/utils/...
File build/android/pylib/utils/emulator.py (right):

https://codereview.chromium.org/17094019/diff/5001/build/android/pylib/utils/...
build/android/pylib/utils/emulator.py:205: '--sdcard', '512M',
On 2013/06/21 01:20:00, gkanwar wrote:
> It probably makes sense to make this value a constant (like API_TARGET above)
so
> that we can tweak this if needed in the future.

Done.

[gkanwar, 2013-06-21 01:31:21]

lgtm

[commit-bot: I haz the power, 2013-06-21 01:39:45]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2013-06-21 01:44:09]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[frankf, 2013-06-21 02:31:56]

lgtm

[commit-bot: I haz the power, 2013-06-21 02:57:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/17094019/10001

[commit-bot: I haz the power, 2013-06-21 08:59:22]

Change committed as 207760