Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 17094016: Disable TLS 1.2 if USE_OPENSSL is defined (such as on Android) to (Closed)

Created:
7 years, 6 months ago by wtc
Modified:
7 years, 6 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Disable TLS 1.2 if USE_OPENSSL is defined (such as on Android) to prevent ClientHello from being larger than 256 bytes. Some broken servers can't handle a large ClientHello. R=agl@chromium.org,rsleevi@chromium.org BUG=90392, 245500, 247691 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/ssl/ssl_config_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wtc
I'd like to get a pre-approval for this CL. I won't check this in before ...
7 years, 6 months ago (2013-06-20 21:58:06 UTC) #1
agl
lgtm
7 years, 6 months ago (2013-06-20 21:59:39 UTC) #2
Ryan Sleevi
lgtm
7 years, 6 months ago (2013-06-20 22:04:00 UTC) #3
wtc
I can reproduce the problem with https://www.wellsfargo.com/. Pruning the cipher suite list (as done in ...
7 years, 6 months ago (2013-06-21 01:39:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/17094016/1
7 years, 6 months ago (2013-06-21 01:41:26 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 08:58:43 UTC) #6
Message was sent while issue was closed.
Change committed as 207759

Powered by Google App Engine
This is Rietveld 408576698