Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17094003: Add skia_exceptinos gyp define (Closed)

Created:
7 years, 6 months ago by borenet
Modified:
7 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add skia_exceptinos gyp define Committed: http://code.google.com/p/skia/source/detail?r=9615

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +9 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
lgtm - can't say no to exceptinos!
7 years, 6 months ago (2013-06-14 15:31:53 UTC) #1
borenet
Patch set 2 renames the define to "skia_win_exceptions".
7 years, 6 months ago (2013-06-14 16:03:43 UTC) #2
robertphillips
lgtm
7 years, 6 months ago (2013-06-14 16:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/17094003/3001
7 years, 6 months ago (2013-06-14 17:02:18 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 17:10:11 UTC) #5
Message was sent while issue was closed. 
Change committed as 9615

Powered by Google App Engine
This is Rietveld 408576698