Issue 17093005: Revert "Improved range analysis for bitwise operations."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17093005: Revert "Improved range analysis for bitwise operations." (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, sra1

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Improved range analysis for bitwise operations." This reverts commit r15170 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15173

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -343 lines)			Patch
M	src/hydrogen-instructions.h	View	3 chunks	+1 line, -56 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+51 lines, -31 lines	0 comments	Download
M	test/cctest/cctest.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	test/cctest/test-bitrange.cc	View	1 chunk	+0 lines, -255 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

rubber-stamp LGTM. For the record, the reason for the revert is compile failures on Windows, ...

7 years, 6 months ago (2013-06-14 17:24:48 UTC) #2

Toon Verwaest

7 years, 6 months ago (2013-06-14 17:25:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15173 (presubmit successful).