Issue 17093002: Remove KeyboardCodeFromGdkEventKey.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17093002: Remove KeyboardCodeFromGdkEventKey. (Closed)

Created:
7 years, 6 months ago by Raphael Kubo da Costa (rakuco)

Modified:
7 years, 6 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Remove KeyboardCodeFromGdkEventKey. The code which used it was removed in r127507, so there's no reason to keep it alive. BUG= R=ben@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206765

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -13 lines)			Patch
	M	ui/base/keycodes/keyboard_code_conversion_gtk.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	ui/base/keycodes/keyboard_code_conversion_gtk.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/17093002/1

7 years, 6 months ago (2013-06-17 16:39:58 UTC) #3

Message was sent while issue was closed.

Change committed as 206765