Issue 17092002: [Android] Call View.postInvalidate on ICS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17092002: [Android] Call View.postInvalidate on ICS (Closed)

Created:
7 years, 6 months ago by boliu

Modified:
7 years, 6 months ago

Reviewers:
bulach, Jay Civelli, Yaron, joth, Sami

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Call View.postInvalidate on ICS Since we are calling postInvalidateOnAnimation on JB+, a better match on ICS would be to call postInvalidate instead of the more synchronous invalidate. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206746

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

boliu

Adding *all* base/android owners since I only have the vague belief this won't break anything ...

7 years, 6 months ago (2013-06-14 14:31:08 UTC) #1

bulach

+skyostil, I think he know all about invalidation.. lgtm for OWNERS if sami is happy.

7 years, 6 months ago (2013-06-17 10:02:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/17092002/1

7 years, 6 months ago (2013-06-17 14:29:50 UTC) #4

Message was sent while issue was closed.

Change committed as 206746

Expand Messages | Collapse Messages