Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 17088005: [Android] Add GetDescription and defer calculating device_utc_offset (Closed)

Created:
7 years, 6 months ago by cjhopman
Modified:
7 years, 6 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Add GetDescription and defer calculating device_utc_offset First, only get the device's utc offset when it is actually needed. Calculating this offset takes about 100ms on a typical device. The build scripts assume that creating an instance of AndroidCommands is not so expensive. Instead, defer calculating this value until it is actually requested. There are currently several cases where the build scripts call adb directly instead of through android_commands just to avoid this extra cost. Second, add a GetDescription method to get a (mostly) user-readable description of the device. TBR=frankf@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207371

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M build/android/pylib/android_commands.py View 1 3 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
7 years, 6 months ago (2013-06-14 19:13:37 UTC) #1
craigdh
lgtm with nit (frank is OOO today). https://codereview.chromium.org/17088005/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/17088005/diff/1/build/android/pylib/android_commands.py#newcode853 build/android/pylib/android_commands.py:853: def DeviceUtcOffset(self): ...
7 years, 6 months ago (2013-06-14 20:48:47 UTC) #2
cjhopman
frankf: TBRed for COMMITTERS
7 years, 6 months ago (2013-06-19 20:01:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/17088005/5001
7 years, 6 months ago (2013-06-20 01:49:17 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 09:09:04 UTC) #5
Message was sent while issue was closed.
Change committed as 207371

Powered by Google App Engine
This is Rietveld 408576698