Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1708433002: Move BookmarksBridge into package with other bookmarks classes. (Closed)

Created:
4 years, 10 months ago by newt (away)
Modified:
4 years, 10 months ago
Reviewers:
Ian Wen, wrong ianwen
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, noyau+watch_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move BookmarksBridge into package with other bookmarks classes. This moves/renames org.chromium.chrome.browser.bookmark.BookmarksBridge to ...bookmarks.BookmarkBridge, which makes the naming and package consistent with other bookmarks-related files. This also renames BookmarksBridgeTest, and removes the "s" from bookmarks_bridge.[cc|h]. BUG=474719 Committed: https://crrev.com/ff7b9e4ce2f49d074e38566a406c2cb936b04f5a Cr-Commit-Position: refs/heads/master@{#375961}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -2820 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 4 chunks +6 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/bookmark/BookmarksBridge.java View 1 chunk +0 lines, -919 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddEditFolderActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBookmarkRow.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkBridge.java View 35 chunks +73 lines, -74 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderRow.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSearchRow.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSearchView.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUndoController.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 7 chunks +15 lines, -15 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/BookmarksBridgeTest.java View 1 chunk +0 lines, -225 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkBridgeTest.java View 13 chunks +49 lines, -49 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java View 8 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/android/bookmarks/bookmark_bridge.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/android/bookmarks/bookmark_bridge.cc View 1 56 chunks +94 lines, -94 lines 0 comments Download
D chrome/browser/android/bookmarks/bookmarks_bridge.h View 1 chunk +0 lines, -272 lines 0 comments Download
D chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 1 chunk +0 lines, -1109 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
newt (away)
PTAL
4 years, 10 months ago (2016-02-17 02:35:42 UTC) #2
wrong ianwen
lgtm
4 years, 10 months ago (2016-02-17 07:11:37 UTC) #4
Ian Wen
lgtm
4 years, 10 months ago (2016-02-17 17:13:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708433002/20001
4 years, 10 months ago (2016-02-17 19:07:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 20:08:38 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 20:09:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff7b9e4ce2f49d074e38566a406c2cb936b04f5a
Cr-Commit-Position: refs/heads/master@{#375961}

Powered by Google App Engine
This is Rietveld 408576698