Issue 17084014: Do not try to shutdown when XIOError happens during startup.

Issue 17084014: Do not try to shutdown when XIOError happens during startup. (Closed)

Created:
7 years, 6 months ago by oshima

Modified:
7 years, 6 months ago

Reviewers:
Lei Zhang, Daniel Erat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Do not try to shutdown when XIOError happens during startup. BUG=245371 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206561

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -8 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_x11.h	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_x11.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 9 (0 generated)

Daniel Erat

I thought you were going to make the pre-message-loop error handler print a friendlier message ...

7 years, 6 months ago (2013-06-14 21:48:49 UTC) #3

oshima

On 2013/06/14 21:48:49, Daniel Erat wrote: > I thought you were going to make the ...

7 years, 6 months ago (2013-06-14 22:00:41 UTC) #4

Daniel Erat

LGTM Ah, sorry, my mistake. I'd assumed that ui::SetX11ErrorHandlers() just restored Xlib's default handlers on ...

7 years, 6 months ago (2013-06-14 22:10:18 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/17084014/1

7 years, 6 months ago (2013-06-14 23:10:22 UTC) #8

Message was sent while issue was closed.

Change committed as 206561