Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1708223005: Loading model test tweak. (Closed)

Created:
4 years, 10 months ago by mattcary
Modified:
4 years, 10 months ago
Reviewers:
Benoit L, blundell
CC:
chromium-reviews, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, droger
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading model test tweak. Extract SimpleLens to test_utils and change how it's plugged into ResourceGraph. This will make it easier to create ResourceGraphs in other tests. Committed: https://crrev.com/82369343882999c0829645d6559d4f3180c4f29e Cr-Commit-Position: refs/heads/master@{#376442}

Patch Set 1 #

Patch Set 2 : push up MakeGraph #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -39 lines) Patch
M tools/android/loading/loading_model.py View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/android/loading/loading_model_unittest.py View 1 8 chunks +8 lines, -37 lines 0 comments Download
M tools/android/loading/test_utils.py View 1 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mattcary
Hi Colin & Benoît: A minor refactoring in test organization to make future testing of ...
4 years, 10 months ago (2016-02-19 13:31:20 UTC) #3
blundell
lgtm
4 years, 10 months ago (2016-02-19 14:00:49 UTC) #4
Benoit L
On 2016/02/19 14:00:49, blundell wrote: > lgtm lgtm
4 years, 10 months ago (2016-02-19 15:04:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708223005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708223005/20001
4 years, 10 months ago (2016-02-19 15:08:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 15:49:21 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 15:50:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82369343882999c0829645d6559d4f3180c4f29e
Cr-Commit-Position: refs/heads/master@{#376442}

Powered by Google App Engine
This is Rietveld 408576698