Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 17076009: linux: tcmalloc does not depend on glib (Closed)

Created:
7 years, 6 months ago by Mostyn Bramley-Moore
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, asaka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

linux: tcmalloc does not depend on glib This seems to have been an old implicit assumption that use_glib==1 meant OS=="linux". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207370

Patch Set 1 #

Patch Set 2 : remove another assumption that glib means linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M base/base.gyp View 1 4 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@jar: does this small patch look OK to you? I can't see any reason why ...
7 years, 6 months ago (2013-06-17 14:59:32 UTC) #1
jar (doing other things)
Will Chan should be more informed... so I'll let him comment.
7 years, 6 months ago (2013-06-17 17:38:00 UTC) #2
willchan no longer on Chromium
lgtm
7 years, 6 months ago (2013-06-17 18:24:54 UTC) #3
Mostyn Bramley-Moore
On 2013/06/17 18:24:54, willchan wrote: > lgtm I noticed another instance of this assumption in ...
7 years, 6 months ago (2013-06-17 19:25:50 UTC) #4
Mostyn Bramley-Moore
@willchan: *ping* :)
7 years, 6 months ago (2013-06-19 08:07:42 UTC) #5
willchan no longer on Chromium
LGTM2 Sorry, I've been sleeping non-stop. Got a cold :(
7 years, 6 months ago (2013-06-19 17:33:12 UTC) #6
Mostyn Bramley-Moore
On 2013/06/19 17:33:12, willchan wrote: > LGTM2 > > Sorry, I've been sleeping non-stop. Got ...
7 years, 6 months ago (2013-06-19 19:33:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/17076009/5001
7 years, 6 months ago (2013-06-19 19:34:28 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-20 09:08:41 UTC) #9
Message was sent while issue was closed.
Change committed as 207370

Powered by Google App Engine
This is Rietveld 408576698