Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 17074012: Separate NaCl switches to their own file. (Closed)

Created:
7 years, 6 months ago by yael.aharon
Modified:
7 years, 6 months ago
Reviewers:
yael.aharon1, jam, Jói
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Separate NaCl switches to their own file. This is part of an effort to componentize NaCl code. BUG=244791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208306

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -40 lines) Patch
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/breakpad_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/app/nacl_fork_delegate_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/common/nacl_cmd_line.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common_constants.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/nacl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/nacl/nacl_broker_listener.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/nacl/nacl_exe_win_64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/nacl/nacl_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/nacl/nacl_main_platform_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/nacl/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/nacl/common/nacl_switches.h View 1 chunk +24 lines, -0 lines 0 comments Download
A components/nacl/common/nacl_switches.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A components/nacl_common.gyp View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yael.aharon1
This patch is identical to the one that was reverted in https://codereview.chromium.org/17379019/ with one exception: ...
7 years, 6 months ago (2013-06-22 01:24:59 UTC) #1
Jói
//components LGTM.
7 years, 6 months ago (2013-06-24 13:14:01 UTC) #2
yael.aharon1
7 years, 6 months ago (2013-06-24 17:23:18 UTC) #3
jam
lgtm
7 years, 6 months ago (2013-06-24 18:18:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17074012/1
7 years, 6 months ago (2013-06-24 18:21:55 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/app/nacl_fork_delegate_linux.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-24 18:22:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17074012/21001
7 years, 6 months ago (2013-06-24 18:42:02 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 23:53:11 UTC) #8
Message was sent while issue was closed.
Change committed as 208306

Powered by Google App Engine
This is Rietveld 408576698