Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17074010: Reland "bookmarks: Convert "Remove" link into a LabelButton."" (Closed)

Created:
7 years, 6 months ago by tfarina
Modified:
7 years, 6 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Reland "bookmarks: Convert "Remove" link into a LabelButton." It was reverted in r207804, because it broke some Bookmark tests in interactive_ui_tests. BUG=231694 TEST=ctrl+D or press the star button in the omnibox, observe the Bookmark Bubble, there should be a "Remove" Button in the left side of "Edit.." button. TBR=msw@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208092

Patch Set 1 #

Patch Set 2 : fix title issue #

Patch Set 3 : fix win_rel? #

Patch Set 4 : hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -72 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h View 1 2 3 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 2 3 8 chunks +56 lines, -58 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
Relanding... Patch set 2 -> http://imgur.com/7NZWtNJ
7 years, 6 months ago (2013-06-22 01:24:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/17074010/2001
7 years, 6 months ago (2013-06-22 01:25:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/17074010/2001
7 years, 6 months ago (2013-06-22 02:34:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, ...
7 years, 6 months ago (2013-06-22 03:27:17 UTC) #4
msw
lgtm
7 years, 6 months ago (2013-06-22 08:40:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/17074010/2001
7 years, 6 months ago (2013-06-22 08:40:36 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=168219
7 years, 6 months ago (2013-06-22 11:23:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/17074010/25003
7 years, 6 months ago (2013-06-22 13:43:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/17074010/20003
7 years, 6 months ago (2013-06-22 15:23:34 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=168246
7 years, 6 months ago (2013-06-22 16:41:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/17074010/20003
7 years, 6 months ago (2013-06-22 18:59:49 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-22 22:16:09 UTC) #12
Message was sent while issue was closed. 
Change committed as 208092

Powered by Google App Engine
This is Rietveld 408576698