src/ast.cc - Issue 17071002: Add soft-deopt for uninitialized assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 17071002: Add soft-deopt for uninitialized assignment (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 0ebbd35be886cdef66de2bb459226000d41750a3..7f00ef30b148d9f9992ae03de0379e9e411a4450 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -135,6 +135,7 @@ Assignment::Assignment(Isolate* isolate,

binary_operation_(NULL),

assignment_id_(GetNextId(isolate)),

is_monomorphic_(false),

+ is_uninitialized_(false),

store_mode_(STANDARD_STORE) { }

@@ -465,6 +466,8 @@ void Assignment::RecordTypeFeedback(TypeFeedbackOracle* oracle,

Property* prop = target()->AsProperty();

ASSERT(prop != NULL);

TypeFeedbackId id = AssignmentFeedbackId();

+ is_uninitialized_ = oracle->StoreIsUninitialized(id);

+ if (is_uninitialized_) return;

is_monomorphic_ = oracle->StoreIsMonomorphicNormal(id);

receiver_types_.Clear();

if (prop->key()->IsPropertyName()) {

« no previous file with comments | « src/ast.h ('k') | src/hydrogen.cc » ('j') | no next file with comments »