Issue 17068015: Adjust do not disturb hovertext on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17068015: Adjust do not disturb hovertext on Mac. (Closed)

Created:
7 years, 6 months ago by dewittj

Modified:
7 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Adjust do not disturb hovertext on Mac. From "Do not disturb" to "Do Not Disturb". BUG=252840 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207981

Patch Set 2 : Use titlecase flag instead. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	ui/base/strings/ui_strings.grd	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nico

https://codereview.chromium.org/17068015/diff/1/ui/base/strings/ui_strings.grd File ui/base/strings/ui_strings.grd (right): https://codereview.chromium.org/17068015/diff/1/ui/base/strings/ui_strings.grd#newcode464 ui/base/strings/ui_strings.grd:464: <if expr="not is_macosx"> We usually check pp_ifdef('use_titlecase').

7 years, 6 months ago (2013-06-21 19:57:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/17068015/5001

7 years, 6 months ago (2013-06-21 21:37:26 UTC) #5

Message was sent while issue was closed.

Change committed as 207981

Expand Messages | Collapse Messages

Issue 17068015: Adjust do not disturb hovertext on Mac. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use titlecase flag instead. #

Messages