Issue 17068010: Fix WebMediaPlayer build with enable_pepper_cdms=0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17068010: Fix WebMediaPlayer build with enable_pepper_cdms=0 (Closed)

Created:
7 years, 6 months ago by spang

Modified:
7 years, 6 months ago

Reviewers:
spang1, wjia(left Chromium), scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Fix WebMediaPlayer build with enable_pepper_cdms=0 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207931

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	webkit/renderer/media/webmediaplayer_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

wjia(left Chromium)

It LG to me. I'd let scherkus@ make the call.

7 years, 6 months ago (2013-06-21 16:32:27 UTC) #2

scherkus (not reviewing)

LGTM ... but what build configuration is including this code but disabling ENABLING_PEPPER_CDMS?

7 years, 6 months ago (2013-06-21 16:49:42 UTC) #3

spang

On 2013/06/21 16:49:42, scherkus wrote: > LGTM ... but what build configuration is including this ...

7 years, 6 months ago (2013-06-21 17:22:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/17068010/1

7 years, 6 months ago (2013-06-21 19:27:45 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/17068010/1

7 years, 6 months ago (2013-06-21 22:08:55 UTC) #6

Message was sent while issue was closed.

Change committed as 207931