Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 17068009: Use TEXTMETRICS for font metrics for Skia/GDI (Closed)

Created:
7 years, 6 months ago by eae
Modified:
7 years, 6 months ago
Reviewers:
Nico, reed1
CC:
chromium-reviews
Visibility:
Public.

Description

Use TEXTMETRICS for font metrics for Skia/GDI Blink currently uses TEXTMETRICS for font metrics on windows, regardless of the font type. Skia currently does not. Set the SK_GDI_ALWAYS_USE_TEXTMETRICS_FOR_FONT_METRICS flag for windows which will instruct Skia to use the same font metrics for the GDI backend as our current GDI implementation. BUG=252705 R=reed@google.com, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M skia/skia.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eae
This won't have any effect unless ENABLE_GDI_FONTS_ON_WINDOWS is unset as we don't yet use skia ...
7 years, 6 months ago (2013-06-21 15:36:15 UTC) #1
reed1
lgtm
7 years, 6 months ago (2013-06-21 15:45:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/17068009/1
7 years, 6 months ago (2013-06-21 15:50:00 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 20:09:21 UTC) #4
Message was sent while issue was closed.
Change committed as 207911

Powered by Google App Engine
This is Rietveld 408576698