Changes to PairingRegistry to facilitate per-platform implementions.

Changes to PairingRegistry to facilitate per-platform implementions.

Implementing the Linux pairing registry delegate required some changes to the cross-platform code. I've isolated them in this CL for clarity:

* Added a timestamp to the Pairing struct and made it a class with a Create method to generate the random information and timestamp.
* Added a callback to AddPairing. For now, this is only used in the unit test.

I also fixed a couple of unrelated linter errors in protocol_mock_objects.

BUG=156182
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206947

[Jamie, 2013-06-16 22:40:52]

ptal

[Jamie, 2013-06-17 20:59:27]

Renato: ping

[rmsousa, 2013-06-17 23:56:10]

lgtm

https://codereview.chromium.org/17063003/diff/2001/remoting/protocol/pairing_...
File remoting/protocol/pairing_registry.h (right):

https://codereview.chromium.org/17063003/diff/2001/remoting/protocol/pairing_...
remoting/protocol/pairing_registry.h:83: // the client_name is empty. Must not
block.
The check in the code is for client_id. client_name can be empty in a valid
pairing.

Also, since now it's a class, rather than describing the condition for an empty
pairing you could just define is_valid()/is_empty() directly.

[Jamie, 2013-06-18 00:16:00]

fyi

https://codereview.chromium.org/17063003/diff/2001/remoting/protocol/pairing_...
File remoting/protocol/pairing_registry.h (right):

https://codereview.chromium.org/17063003/diff/2001/remoting/protocol/pairing_...
remoting/protocol/pairing_registry.h:83: // the client_name is empty. Must not
block.
On 2013/06/17 23:56:10, rmsousa wrote:
> The check in the code is for client_id. client_name can be empty in a valid
> pairing.
> 
> Also, since now it's a class, rather than describing the condition for an
empty
> pairing you could just define is_valid()/is_empty() directly.

Done.

[commit-bot: I haz the power, 2013-06-18 00:16:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/17063003/8001

[commit-bot: I haz the power, 2013-06-18 12:12:07]

Change committed as 206947