third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h - Issue 1706163002: Refactoring: Remove an argument 'enabled' from onHeapProfilingEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h

Issue 1706163002: Refactoring: Remove an argument 'enabled' from onHeapProfilingEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp ('k') | third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h

diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h

index e0166d88c318e358b9b81a8ab6d211e3b3d9759b..646448cc6a2b56f54c563eb697aaffc17b501fb4 100644

--- a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h

+++ b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h

@@ -33,7 +33,7 @@ public:

// WebMemoryDumpProvider implementation.

bool onMemoryDump(WebMemoryDumpLevelOfDetail, WebProcessMemoryDump*) override;

bool supportsHeapProfiling() override { return true; }

- void onHeapProfilingEnabled(bool) override;

+ void onHeapProfilingEnabled() override;

// The returned WebMemoryAllocatorDump is owned by

// BlinkGCMemoryDumpProvider, and should not be retained (just used to