Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: third_party/WebKit/public/platform/WebMemoryDumpProvider.h

Issue 1706163002: Refactoring: Remove an argument 'enabled' from onHeapProfilingEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebMemoryDumpProvider_h 5 #ifndef WebMemoryDumpProvider_h
6 #define WebMemoryDumpProvider_h 6 #define WebMemoryDumpProvider_h
7 7
8 #include "WebCommon.h" 8 #include "WebCommon.h"
9 9
10 namespace blink { 10 namespace blink {
(...skipping 29 matching lines...) Expand all
40 // considered invalid. 40 // considered invalid.
41 virtual bool onMemoryDump(WebMemoryDumpLevelOfDetail, WebProcessMemoryDump*) = 0; 41 virtual bool onMemoryDump(WebMemoryDumpLevelOfDetail, WebProcessMemoryDump*) = 0;
42 42
43 // Because Blink cannot depend on base, heap profiling bookkeeping has to 43 // Because Blink cannot depend on base, heap profiling bookkeeping has to
44 // be done in the glue layer for now. This method allows the glue layer to 44 // be done in the glue layer for now. This method allows the glue layer to
45 // detect whether the current dump provider supports heap profiling. 45 // detect whether the current dump provider supports heap profiling.
46 // TODO(ruuda): Remove once wtf can depend on base and do bookkeeping in the 46 // TODO(ruuda): Remove once wtf can depend on base and do bookkeeping in the
47 // provider itself. 47 // provider itself.
48 virtual bool supportsHeapProfiling() { return false; } 48 virtual bool supportsHeapProfiling() { return false; }
49 49
50 // Called by the memory dump manager to enable heap profiling (with true) or 50 // Called by the memory dump manager to enable heap profiling.
51 // called to disable heap profiling (with false). 51 virtual void onHeapProfilingEnabled() {}
52 virtual void onHeapProfilingEnabled(bool enabled) {}
53 }; 52 };
54 53
55 } // namespace blink 54 } // namespace blink
56 55
57 #endif // WebMemoryDumpProvider_h 56 #endif // WebMemoryDumpProvider_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698