Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 17057003: Add command line switch to enable region based columns. (Closed)

Created:
7 years, 6 months ago by mstensho (USE GERRIT)
Modified:
7 years, 6 months ago
Reviewers:
jamesr, sky, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add command line switch to enable region based columns. This needs to be a separate switch - we cannot lump it together with --enable-experimental-webkit-features , because we don't want to unconditionally enable region based columns when running LayoutTests (there are LayoutTests that compare rendering in the old and new multicol implementations, using internals.settings.setRegionBasedColumnsEnabled(true)). BUG=242905 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/renderer/webpreferences_renderer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mstensho (USE GERRIT)
7 years, 6 months ago (2013-06-14 09:29:44 UTC) #1
mstensho (USE GERRIT)
7 years, 6 months ago (2013-06-17 09:54:51 UTC) #2
Jói
LGTM. I reviewed the entire change, although I am not a good reviewer for the ...
7 years, 6 months ago (2013-06-17 19:04:49 UTC) #3
jamesr
webkit/ lgtm
7 years, 6 months ago (2013-06-17 19:31:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/17057003/1
7 years, 6 months ago (2013-06-18 08:20:31 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=9893
7 years, 6 months ago (2013-06-18 08:37:48 UTC) #6
mstensho (USE GERRIT)
Oops, I'm new here. Sorry for the mess. I went throught various OWNERS files, picked ...
7 years, 6 months ago (2013-06-18 08:47:55 UTC) #7
sky
content/browser LGTM
7 years, 6 months ago (2013-06-18 13:46:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/17057003/1
7 years, 6 months ago (2013-06-18 13:49:14 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 15:51:16 UTC) #10
Message was sent while issue was closed.
Change committed as 207005

Powered by Google App Engine
This is Rietveld 408576698