[Autofill] Remove the "Disable native Autofill UI" flag.

[Autofill] Remove the "Disable native Autofill UI" flag.

BUG=51644
TEST=none
R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207812

[blundell, 2013-06-18 07:36:35]

You should be able to get rid of AutofillManager::IsNativeUiEnabled() as well.

[Ilya Sherman, 2013-06-18 11:00:16]

On 2013/06/18 07:36:35, blundell wrote:
> You should be able to get rid of AutofillManager::IsNativeUiEnabled() as well.

Yes, as well as lots of other code, but I'm aiming for small CLs :)

[Evan Stade, 2013-06-19 00:45:15]

lgtm

[commit-bot: I haz the power, 2013-06-19 00:49:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/17052008/4001

[commit-bot: I haz the power, 2013-06-19 00:49:47]

Failed to apply patch for
components/autofill/content/browser/autofill_driver_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/autofill/content/browser/autofill_driver_impl.cc
  Hunk #3 FAILED at 50.
  1 out of 3 hunks FAILED -- saving rejects to file
components/autofill/content/browser/autofill_driver_impl.cc.rej

Patch:       components/autofill/content/browser/autofill_driver_impl.cc
Index: components/autofill/content/browser/autofill_driver_impl.cc
diff --git a/components/autofill/content/browser/autofill_driver_impl.cc
b/components/autofill/content/browser/autofill_driver_impl.cc
index
02963520d9e218aaacca8bf618afd6b390f49196..752b103a2b2064fe18e30b60509bacfe3f24b739
100644
--- a/components/autofill/content/browser/autofill_driver_impl.cc
+++ b/components/autofill/content/browser/autofill_driver_impl.cc
@@ -23,8 +23,7 @@ void AutofillDriverImpl::CreateForWebContentsAndDelegate(
     content::WebContents* contents,
     autofill::AutofillManagerDelegate* delegate,
     const std::string& app_locale,
-    AutofillManager::AutofillDownloadManagerState enable_download_manager,
-    bool enable_native_ui) {
+    AutofillManager::AutofillDownloadManagerState enable_download_manager) {
   if (FromWebContents(contents))
     return;
 
@@ -32,8 +31,7 @@ void AutofillDriverImpl::CreateForWebContentsAndDelegate(
                         new AutofillDriverImpl(contents,
                                                delegate,
                                                app_locale,
-                                               enable_download_manager,
-                                               enable_native_ui));
+                                               enable_download_manager));
   // Trigger the lazy creation of AutocheckoutWhitelistManagerService, and
   // schedule a fetch of the Autocheckout whitelist file if it's not already
   // loaded. This helps ensure that the whitelist will be available by the time
@@ -52,18 +50,15 @@ AutofillDriverImpl::AutofillDriverImpl(
     content::WebContents* web_contents,
     autofill::AutofillManagerDelegate* delegate,
     const std::string& app_locale,
-    AutofillManager::AutofillDownloadManagerState enable_download_manager,
-    bool enable_native_ui)
+    AutofillManager::AutofillDownloadManagerState enable_download_manager)
     : content::WebContentsObserver(web_contents),
       autofill_manager_(this, delegate, app_locale, enable_download_manager) {
-  if (enable_native_ui) {
-    // TODO(blundell): Eliminate AutofillExternalDelegate being a WCUD and
-    // transfer ownership of it to this class.
-    AutofillExternalDelegate::CreateForWebContentsAndManager(
-        web_contents, &autofill_manager_);
-    autofill_manager_.SetExternalDelegate(
-        AutofillExternalDelegate::FromWebContents(web_contents));
-  }
+  // TODO(blundell): Eliminate AutofillExternalDelegate being a WCUD and
+  // transfer ownership of it to this class.
+  AutofillExternalDelegate::CreateForWebContentsAndManager(
+      web_contents, &autofill_manager_);
+  autofill_manager_.SetExternalDelegate(
+      AutofillExternalDelegate::FromWebContents(web_contents));
 }
 
 AutofillDriverImpl::~AutofillDriverImpl() {}

[Ilya Sherman, 2013-06-19 01:04:48]

+OWNERS: 

benm for android_webview/
avi for chrome/browser/ui/browser_tab_contents.cc
tedchoc for chrome/browser/android/tab_android.cc

[Ted C, 2013-06-19 01:10:35]

tab_android lgtm

[Avi (use Gerrit), 2013-06-19 04:42:05]

lgtm

[benm (inactive), 2013-06-19 09:47:21]

lgtm

aw lgtm

[commit-bot: I haz the power, 2013-06-21 03:38:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/17052008/27001

[commit-bot: I haz the power, 2013-06-21 14:32:02]

Change committed as 207812