Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 17045008: HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' meth… (Closed)

Created:
7 years, 6 months ago by Mikhail
Modified:
7 years, 6 months ago
CC:
blink-reviews, shans, loislo+blink_chromium.org, alancutter (OOO until 2018), eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dstockwell, dglazkov+blink, f(malita), adamk+blink_chromium.org, darktears, pdr, Stephen Chennney, Steve Block, jeez, (unused - use chromium), tkent, gmorrita, Julien - ping for review, Chris Evans, tony
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods The order of the template arguments at HashSet alternate 'find', 'contains' and 'add' methods is reversed so that callers can just pass the translator and let the compiler deduce input argument type. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -70 lines) Patch
M Source/core/dom/QualifiedName.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateTransformElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEOffsetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFETileElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLineElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStopElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyledTransformableElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSymbolElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTRefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGViewElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/HashSet.h View 5 chunks +6 lines, -10 lines 0 comments Download
M Source/wtf/text/AtomicString.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mikhail
The order of the template arguments at HashSet alternate 'find', 'contains' and 'add' methods is ...
7 years, 6 months ago (2013-06-21 17:48:35 UTC) #1
Stephen Chennney
lgtm
7 years, 6 months ago (2013-06-21 18:04:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/17045008/1
7 years, 6 months ago (2013-06-21 18:05:10 UTC) #3
Stephen Chennney
I checked blame, and Darin Adler added the FIXME originally. So I'm happy with this. ...
7 years, 6 months ago (2013-06-21 18:05:30 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2134
7 years, 6 months ago (2013-06-21 18:19:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/17045008/1
7 years, 6 months ago (2013-06-21 21:16:38 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2143
7 years, 6 months ago (2013-06-21 21:35:48 UTC) #7
Mikhail
Could please a 'wtf' folder owner take a look?
7 years, 6 months ago (2013-06-24 08:03:47 UTC) #8
Hajime Morrita
lgtm. This is nice!
7 years, 6 months ago (2013-06-24 09:06:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/17045008/1
7 years, 6 months ago (2013-06-24 09:53:20 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 11:11:17 UTC) #11
Message was sent while issue was closed.
Change committed as 152944

Powered by Google App Engine
This is Rietveld 408576698