Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 17041003: Remove the switches kSilentDumpOnDCHECK and kMemoryProfiling from NaCl and broker processes. (Closed)

Created:
7 years, 6 months ago by yael.aharon
Modified:
7 years, 6 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the switches kSilentDumpOnDCHECK and kMemoryProfiling from NaCl and broker processes. The reason for removing these flags is because they seem to not be used, and they cause a problem in moving NaCl code to components, because they are defined in the chrome layer. This is in preparation to move NaCl code to components. BUG=244791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/common/nacl_cmd_line.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
yael.aharon1
This is broken off from https://codereview.chromium.org/16881004/ Can you please review?
7 years, 6 months ago (2013-06-21 00:17:46 UTC) #1
yael.aharon1
7 years, 6 months ago (2013-06-21 00:29:55 UTC) #2
Mark Seaborn
LGTM. Is there a particular reason to remove these two? I mean, the list of ...
7 years, 6 months ago (2013-06-21 01:07:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17041003/1
7 years, 6 months ago (2013-06-21 02:10:42 UTC) #4
yael.aharon1
On 2013/06/21 01:07:39, Mark Seaborn wrote: > LGTM. Is there a particular reason to remove ...
7 years, 6 months ago (2013-06-21 02:10:59 UTC) #5
yael.aharon1
On 2013/06/21 01:07:39, Mark Seaborn wrote: > LGTM. Is there a particular reason to remove ...
7 years, 6 months ago (2013-06-21 02:20:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=11146
7 years, 6 months ago (2013-06-21 02:21:01 UTC) #7
yael.aharon1
jam@ could you please rubber stamp?
7 years, 6 months ago (2013-06-21 02:22:27 UTC) #8
Mark Seaborn
On 20 June 2013 19:20, <yael.aharon@chromium.org> wrote: > On 2013/06/21 01:07:39, Mark Seaborn wrote: > ...
7 years, 6 months ago (2013-06-21 02:25:14 UTC) #9
Mark Seaborn
On 20 June 2013 19:20, <yael.aharon@chromium.org> wrote: > On 2013/06/21 01:07:39, Mark Seaborn wrote: > ...
7 years, 6 months ago (2013-06-21 02:25:14 UTC) #10
yael.aharon1
On 2013/06/21 02:25:14, Mark Seaborn wrote: > On 20 June 2013 19:20, <mailto:yael.aharon@chromium.org> wrote: > ...
7 years, 6 months ago (2013-06-21 02:34:45 UTC) #11
Mark Seaborn
On 20 June 2013 19:10, <yael.aharon@chromium.org> wrote: > On 2013/06/21 01:07:39, Mark Seaborn wrote: > ...
7 years, 6 months ago (2013-06-21 15:50:46 UTC) #12
Mark Seaborn
On 20 June 2013 19:10, <yael.aharon@chromium.org> wrote: > On 2013/06/21 01:07:39, Mark Seaborn wrote: > ...
7 years, 6 months ago (2013-06-21 15:50:46 UTC) #13
yael.aharon
I have to alternate the accounts because my company policy requires me to submit patches ...
7 years, 6 months ago (2013-06-21 16:00:43 UTC) #14
yael.aharon
I have to alternate the accounts because my company policy requires me to submit patches ...
7 years, 6 months ago (2013-06-21 16:00:48 UTC) #15
jam
lgtm
7 years, 6 months ago (2013-06-21 16:07:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17041003/1
7 years, 6 months ago (2013-06-21 16:21:44 UTC) #17
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 20:24:55 UTC) #18
Message was sent while issue was closed.
Change committed as 207914

Powered by Google App Engine
This is Rietveld 408576698