Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5534)

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 17038002: Separate the NTP app ordering from the app list app ordering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add sync test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs.cc
diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc
index 2073106e391b4ef0c4b9539435aa1cada36e06ab..2651f3bf88aca1123b762ce1b29d54bea2a9f10e 100644
--- a/chrome/browser/extensions/extension_prefs.cc
+++ b/chrome/browser/extensions/extension_prefs.cc
@@ -1241,6 +1241,7 @@ void ExtensionPrefs::OnExtensionUninstalled(const std::string& extension_id,
const Manifest::Location& location,
bool external_uninstall) {
extension_sorting_->ClearOrdinals(extension_id);
+ app_list_extension_ordering_->Erase(extension_id);
// For external extensions, we save a preference reminding ourself not to try
// and install the extension anymore (except when |external_uninstall| is
@@ -1685,6 +1686,7 @@ void ExtensionPrefs::InitPrefStore() {
MigratePermissions(extension_ids);
MigrateDisableReasons(extension_ids);
extension_sorting_->Initialize(extension_ids);
+ app_list_extension_ordering_->Initialize(extension_ids);
// Store extension controlled preference values in the
// |extension_pref_value_map_|, which then informs the subscribers
@@ -1890,6 +1892,7 @@ ExtensionPrefs::ExtensionPrefs(
install_directory_(root_dir),
extension_pref_value_map_(extension_pref_value_map),
extension_sorting_(new ExtensionSorting(this, prefs)),
+ app_list_extension_ordering_(new AppListExtensionOrdering(this)),
content_settings_store_(new ContentSettingsStore()),
time_provider_(time_provider.Pass()),
extensions_disabled_(extensions_disabled) {

Powered by Google App Engine
This is Rietveld 408576698